Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexed (resp. named) property enumerator should return numbers (strings and symbols) only. #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Indexed (resp. named) property enumerator should return numbers (strings and symbols) only. #93

wants to merge 2 commits into from

Conversation

iamstolis
Copy link

This PR fixes #87

@iamstolis
Copy link
Author

The tests that are failing are failing against the current tip of master branch already. For example, one cannot expect the tests to pass on an ancient version of Node.js when mocha (that is used to run the tests) is using an arrow function (i.e. a language feature not available these days).

@hackmod hackmod mentioned this pull request Sep 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken on node master (soon to be Node 10)
1 participant
@iamstolis