Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node v12.0.0 #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Node v12.0.0 #98

wants to merge 1 commit into from

Conversation

lxe
Copy link

@lxe lxe commented Apr 25, 2019

  • Remove deprecated IsNearDeath
  • Try a bunch of things with ->Call until it works
  • Fix mocha command flags

@javenwang javenwang mentioned this pull request Jun 28, 2019
Open
@mhertsch
Copy link

mhertsch commented Sep 17, 2019 •
edited
Loading

Did you notice, that one of the unit-tests is creating a core-dump with Node 10 and 12? It does not happen with 8.

The test is called 'should proxy enumeration' in test/weakref.js

It seems, the tests in the current master are already failing when installed with Node 10.

@hackmod hackmod mentioned this pull request Sep 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lxe @mhertsch