Skip to content

Anrp/workflow#12

Open
anrp-tri wants to merge 3 commits intoToyotaResearchInstitute:mainfrom
anrp-tri:anrp/workflow
Open

Anrp/workflow#12
anrp-tri wants to merge 3 commits intoToyotaResearchInstitute:mainfrom
anrp-tri:anrp/workflow

Conversation

@anrp-tri
Copy link
Collaborator

@anrp-tri anrp-tri commented Oct 16, 2023

This change is Reviewable

Copy link
Contributor

@amcastro-tri amcastro-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might help the review to update PR title and description.
E.g. What is this for? is this part of a PR train?

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@anrp-tri
Copy link
Collaborator Author

This simply runs bazel build in the GH action container (also gets enough of the used drake commit to install prereqs)
No train for this...just the beginning.

@anrp-tri
Copy link
Collaborator Author

Copy link
Contributor

@amcastro-tri amcastro-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what I am looking at, pardon my ignorance.
What does this exactly mean? that when we push a commit into a PR IDTO gets build in CI? and from that log it'd seem that tests are still not running? (but pressumably will in fugure PRs)

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants