ENG-53074: adding edge decision svc config #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varkey98
requested review from
prodion23,
tim-mwangi,
ryanericson,
shashank11p and
puneet-traceable
varkey98
commented
Nov 13, 2024
| @@ -137,10 +142,10 @@ message LogFileConfig { | |||
| } | |||
|
|
|||
| message MetricsLogConfig { | |||
| // set this flag to print metrics in logs | |||
There was a problem hiding this comment.
formatting changes
varkey98
commented
Nov 13, 2024
| google.protobuf.StringValue value_expiration_period = 5; | ||
| // set the span type for rate limited spans | ||
| SpanType span_type = 6; | ||
| // set this flag to enable rate limiter |
There was a problem hiding this comment.
just formatting changes
ryanericson
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.