ENG-56825: add tenant id configuration for libtraceable #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varkey98
requested review from
prodion23,
tim-mwangi,
ryanericson and
puneet-traceable
tim-mwangi
reviewed
Feb 11, 2025
| @@ -45,6 +45,8 @@ message AgentConfig { | |||
| // Goagent specific config | |||
| GoAgent goagent = 18; | |||
|
|
|||
| // tenant id for which the filter is initialised | |||
There was a problem hiding this comment.
Why is this in the config? Ideally it would come from a function of the token and can be passed internally. So I am not sure why it would need to be exposed to the public config.
There was a problem hiding this comment.
I was thinking of adding it to the config file because at this function we dont have to change anything. But just realised it's a bad idea exposing to the public config. Will close this pr, thanks.
|
Closing this pr as exposing tenant id to config file is a bad idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.