refactor: mark fields as readonly#132
Merged
StuartFerguson merged 1 commit intomainfrom Sep 18, 2025
Merged
Conversation
This PR updates class fields that are only assigned during construction to be `readonly`, improving immutability and ensuring thread-safety. - **Fields initialized only in constructors can be made `readonly`**: Several private fields (`Requests`, `DomainService`, and `AggregateRepository`) were found to be assigned only at declaration or inside constructors. Each has been prefixed with the `readonly` modifier to prevent unintended reassignment and better document their immutability. > This Autofix was generated by AI. Please review the change before merging.
|
Here's the code health analysis summary for commits Analysis Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates class fields that are only assigned during construction to be
readonly, improving immutability and ensuring thread-safety.readonly: Several private fields (Requests,DomainService, andAggregateRepository) were found to be assigned only at declaration or inside constructors. Each has been prefixed with thereadonlymodifier to prevent unintended reassignment and better document their immutability.