Upgrade to .NET 9.0 and enhance error handling#114
Merged
StuartFerguson merged 13 commits intomainfrom Jun 9, 2025
Merged
Conversation
- Updated project files to target .NET 9.0. - Modified GitHub Actions workflows to install .NET 9.0. - Updated NuGet package references to latest versions compatible with .NET 9.0. - Changed return types in `ApiClient` methods to `Result<T>` for improved error handling. - Enhanced `PermissionsService` to handle failures when loading permissions data. - Updated request handlers to return `Result<T>` types, improving error management. - Improved error handling in `DataHelperFunctions` when fetching contracts. - Updated Dockerfile to use .NET 9.0 SDK. - Adjusted integration tests for compatibility with new result types. - Overall improvements to code structure for better maintainability and error handling.
This commit updates the `pullrequest.yml` file to include: - A new step to install .NET version 9.x using `actions/[email protected]`. - A step to trust a certificate by installing the `expect` package and configuring the certificate with a specified path and password.
Added connection strings for ConfigurationDbContext and AuthenticationDbContext. Removed connection string for PersistedGrantDbContext. Retained existing logging configuration settings.
- Updated DataHelperFunctions to handle cases with no comparison dates. - Added necessary using directives in Dashboard.cshtml.cs for view rendering. - Adjusted MountAsync method to ensure proper order of fetching data. - Introduced GetSalesValueByHourChart method for generating sales charts. - Initialized properties for TodaysSales and related models to prevent null references.
Updated browser initialization logic in `Hooks.cs` for the `EstateManagementUI.IntegrationTests.Common` namespace. - Assigned "Edge" directly to the `browser` variable. - Added `--start-maximized` argument for Chrome and Edge options. - Streamlined Edge options setup with method chaining. - Simplified retry logic for initializing `EdgeDriver`.
- Set WebDriver window size to 1920x1080 in headless mode in EstateManagementUiSteps.cs. - Added using directive for TransactionProcessor.Database.Entities.Summary in Extensions.cs. - Changed headless mode argument from `--headless=new` to `--headless` in Hooks.cs. - Corrected window size argument format in WithWindowSize method in Hooks.cs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApiClientmethods toResult<T>for improved error handling.PermissionsServiceto handle failures when loading permissions data.Result<T>types, improving error management.DataHelperFunctionswhen fetching contracts.Closes #113