Add test coverage for Contracts Edit Page

[Copilot]

Completed: Code Coverage Improvement for Contracts Edit Page

✅ All tasks completed successfully

Summary

Created comprehensive test coverage for the Contracts Edit Page with 19 test cases following patterns from EstateIndexPageTests.cs as specified in the issue.

Test Coverage Added

Basic Rendering (3 tests)

• Page renders correctly
• Contract details are displayed
• Page title is set correctly

Button Finding (6 tests)

Following EstateIndexPageTests patterns using FindAll("button") and FirstOrDefault():

• Cancel button can be found and clicked
• Update Contract button exists
• Add Product button can be found and clicked
• Remove Product button exists (with title attribute)
• Add Fee button can be found
• Remove Fee button exists (with title attribute)

Navigation Verification (2 tests)

Using _fakeNavigationManager.Uri.ShouldContain() pattern:

• BackToView navigates to /contracts/{id}
• BackToList navigates to /contracts

Modal Interactions (4 tests)

• Add Product button opens product modal
• Add Fee button opens fee modal
• Product modal has Cancel button
• Fee modal has Cancel button

Data Display (4 tests)

• Products are displayed when present
• Empty state shown when no products
• Error handling for contract not found
• Operator name displayed as read-only

Code Quality

• Addressed all code review feedback
• Improved button selectors using type attributes
• Used descriptive variable names
• Consistent with existing test patterns
• All tests follow Arrange-Act-Assert pattern
• Fixed compilation errors (correct model types)
• Fixed test failures (correct enum values)

Coverage Statistics

• Before: 0 tests for Contracts Edit Page
• After: 19 comprehensive tests
• Total Lines Added: 645 lines of test code

Files Changed

• ✅ EstateManagementUI.BlazorServer.Tests/Pages/Contracts/ContractsEditPageTests.cs (new file)

Build & Test Fixes

• Fixed model type errors that prevented compilation:
  • Used correct ContractProductTransactionFeeModel instead of TransactionFeeModel
  • Fixed CalculationType and FeeType to use Int32 values (0, 1) instead of strings
• Fixed test failures:
  • Changed ProductType from "Mobile" to "NotSet" (valid enum value)
  • Matches pattern used in ContractsIndexPageTests

Security

No production code changes - only test additions. No security vulnerabilities introduced.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Improve Code Coverage on Contracts Edit Page</issue_title>
<issue_description>Use the estate index page tests as a guide on how to find buttons and also verify navigation</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Improve Code Coverage on Contracts Edit Page #715

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[StuartFerguson]

@copilot code not building can you take a look

[Copilot]

@copilot code not building can you take a look

Fixed in commit 6dbefae. The issue was:

1. Used wrong model name TransactionFeeModel instead of ContractProductTransactionFeeModel
2. Assigned strings to CalculationType and FeeType properties which are Int32 (should be 0 for Fixed/Merchant, 1 for Percentage/ServiceProvider)

The tests should now compile correctly.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet build EstateManagementUI.BlazorServer.Tests/EstateManagementUI.BlazorServer.Tests.csproj (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[StuartFerguson]

@copilot can you look at the test failures

❌ ContractsEdit_AddFeeButton_OpensModal
System.ArgumentException : Requested value 'Mobile' was not found.
❌ ContractsEdit_WithProductHavingFees_HasAddFeeButton
System.ArgumentException : Requested value 'Mobile' was not found.
❌ ContractsEdit_WithProducts_DisplaysProductList
System.ArgumentException : Requested value 'Mobile' was not found.
❌ ContractsEdit_WithProducts_HasRemoveProductButton
System.ArgumentException : Requested value 'Mobile' was not found.
❌ ContractsEdit_WithTransactionFees_HasRemoveFeeButton
System.ArgumentException : Requested value 'Mobile' was not found.
❌ ContractsEdit_FeeModal_HasCancelButton
System.ArgumentException : Requested value 'Mobile' was not found.

[Copilot]

@copilot can you look at the test failures

❌ ContractsEdit_AddFeeButton_OpensModal
...

Fixed in commit 7f52d65. The issue was using an invalid ProductType value "Mobile". Changed to "NotSet" which is a valid enum value and matches the pattern used in ContractsIndexPageTests.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet build EstateManagementUI.BlazorServer/EstateManagementUI.BlazorServer.csproj grep -l Type t.razor.cs /home/REDACTED/.local/bin/grep Type sers.cshtml.cs cal/bin/grep grep -l Type .cs ndor/bin/grep Type s rep grep (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[StuartFerguson]

@copilot can you revisit this as coverage on edit page is still low