Add comprehensive test coverage for Merchants Edit page#757
Merged
StuartFerguson merged 3 commits intomainfrom Feb 7, 2026
Merged
Add comprehensive test coverage for Merchants Edit page#757StuartFerguson merged 3 commits intomainfrom
StuartFerguson merged 3 commits intomainfrom
Conversation
Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve code coverage on merchants edit page
Add comprehensive test coverage for Merchants Edit page
Feb 7, 2026
Member
|
@copilot something not right in the tests |
The Edit component was declaring its own private fields for activeTab, errorMessage, and successMessage, which shadowed the protected fields from CustomComponentBase. This prevented SetActiveTab() from working correctly since it updated the base class field but the UI read from the local field. Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Contributor
Author
Fixed in commit 5d3ee68. The issue was that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Coverage Added (27 tests)
Created comprehensive test coverage following patterns from
EstateIndexPageTests.cs:Bug Fix (Critical)
Fixed field shadowing bug where
Edit.razor.csdeclared private fields that shadowed the protected fields fromCustomComponentBase:activeTab,errorMessage,successMessageOnInitializedAsync()to properly initializeactiveTabOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.