Skip to content

Make Deposit Screen: shorter input fields, single cancel button, and modal dialog#810

Merged
StuartFerguson merged 6 commits intomainfrom
copilot/make-deposit-screen-changes
Mar 10, 2026
Merged

Make Deposit Screen: shorter input fields, single cancel button, and modal dialog#810
StuartFerguson merged 6 commits intomainfrom
copilot/make-deposit-screen-changes

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

The deposit screen had full-width input fields and has been converted from a full page to a modal dialog that opens inline on the Merchants Index page.

Changes

  • Input widths: Changed all form inputs (depositAmount, depositDate, depositReference) from w-full to w-1/2
  • Cancel button: A single Cancel button in the modal footer alongside the submit button; backdrop click also dismisses the modal
  • Modal dialog: The deposit form now opens as an overlay modal on the Merchants Index page instead of navigating to a separate full-screen page. Clicking "Make Deposit" on any merchant shows the modal
  • Test coverage: Added tests asserting modal open/close behaviour, single cancel button, success flow, and graceful handling when merchant lookup fails
// Index.razor.cs
- private void MakeDeposit(Guid merchantId) => this.NavigationManager.NavigateToMakeMerchantDeposit(merchantId);
+ private async Task MakeDeposit(Guid merchantId) { /* opens deposit modal */ }

The standalone /merchants/{id}/deposit route remains accessible for direct URL access.

Original prompt

This section details on the original issue you should resolve

<issue_title>Make Deposit Screen</issue_title>
<issue_description>- make text boxes a bit shorter

  • 2 cancel buttons</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Update deposit screen with shorter text boxes and additional cancel buttons Make Deposit Screen: shorter input fields and 2 cancel buttons Mar 9, 2026
@StuartFerguson
Copy link
Copy Markdown
Member

@copilot can this be made into a modal dialog rather than a full screen ?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 10, 2026

@copilot can this be made into a modal dialog rather than a full screen ?

Done in commit f1c2990. The deposit form now opens as a modal dialog directly on the Merchants Index page instead of navigating to a full page. Clicking "Make Deposit" on any merchant shows an overlay modal with the form, and both Cancel buttons (header and footer) close the modal and return to the list. The standalone /merchants/{id}/deposit route remains accessible for direct URL access.

Copilot AI changed the title Make Deposit Screen: shorter input fields and 2 cancel buttons Make Deposit Screen: shorter input fields, 2 cancel buttons, and modal dialog Mar 10, 2026
@StuartFerguson
Copy link
Copy Markdown
Member

@copilot one final thing remove the top cancel button please

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 10, 2026

@copilot one final thing remove the top cancel button please

Done in commit 29ba8d5. The top Cancel button has been removed from the modal header — only the Cancel button in the form footer remains.

Copilot AI changed the title Make Deposit Screen: shorter input fields, 2 cancel buttons, and modal dialog Make Deposit Screen: shorter input fields, single cancel button, and modal dialog Mar 10, 2026
Introduced a using alias directive for EstateManagementUI.BlazorServer.Models.MerchantModels as MerchantModels. This simplifies references to types within the MerchantModels namespace throughout the file.
The prlinked.yml GitHub Actions workflow has been deleted. This removes all automation for moving linked issues, formatting PR dates, and handling project columns on pull request events. The repository will no longer perform these actions automatically.
@StuartFerguson StuartFerguson marked this pull request as ready for review March 10, 2026 09:30
@StuartFerguson StuartFerguson merged commit 010d1ef into main Mar 10, 2026
7 checks passed
@StuartFerguson StuartFerguson added the bug Bugs and error-prone code label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs and error-prone code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Deposit Screen

2 participants