Update reporting ID properties and mappings for contracts#816
Merged
StuartFerguson merged 2 commits intomainfrom Mar 13, 2026
Merged
Update reporting ID properties and mappings for contracts#816StuartFerguson merged 2 commits intomainfrom
StuartFerguson merged 2 commits intomainfrom
Conversation
Renamed ProductReportingId to ContractProductReportingId in ContractProduct and updated its JSON property. Added ContractProductTransactionFeeReportingId to ContractProductTransactionFee. Updated mapping logic in ModelFactory and APIModelFactory to use the new property names. Made result type explicit in ContractUIService.GetContracts for clarity. These changes ensure consistent naming and mapping of reporting ID fields across models and services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed ProductReportingId to ContractProductReportingId in ContractProduct and updated its JSON property. Added ContractProductTransactionFeeReportingId to ContractProductTransactionFee. Updated mapping logic in ModelFactory and APIModelFactory to use the new property names. Made result type explicit in ContractUIService.GetContracts for clarity. These changes ensure consistent naming and mapping of reporting ID fields across models and services.
closes #803