Add merchant schedule screen with year dropdown, read-only view access, editable schedule maintenance, and past-month lockout#829
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 1 medium |
🟢 Metrics 46 complexity · 4 duplication
Metric Results Complexity 46 Duplication 4
TIP This summary will be updated as you push new changes. Give us feedback
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/29ec46de-60e8-40bd-b189-413834e552ce Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/29ec46de-60e8-40bd-b189-413834e552ce Co-authored-by: StuartFerguson <[email protected]>
|
@copilot screen looks good, can you make the year a dropdown for say the next 10 years |
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/6fd7e708-c9e9-4e80-b2eb-3847e027b2dc Co-authored-by: StuartFerguson <[email protected]>
|
@copilot another requirement is for the month an invalid date cannot be entered e.g. 31st Novemeber, but be careful with february as some years 29 is valid but others its invalid |
Done in 9b5156a. The year field is now a dropdown covering the current year plus the next 9 years, and I added a focused page test for the option range. Screenshot: https://github.com/user-attachments/assets/2b835bf3-95f4-4073-b8e4-bad79f00aebd Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/be92fbb6-6098-46d4-bfe1-ae06d1c40e2a Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/be92fbb6-6098-46d4-bfe1-ae06d1c40e2a Co-authored-by: StuartFerguson <[email protected]>
Handled in 1ef8461. The schedule save validation already uses the selected year and month to block invalid day numbers, so November 31 is rejected, February 29 is allowed for leap years, and February 29 is rejected for non-leap years. I added focused page tests to cover those cases. Screenshot: https://github.com/user-attachments/assets/b8b2c455-234d-4b1b-aca9-154fb676b98e Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot ok slight requirement change, on the view merchant screen I want a vew read only merchant schedule, on the edit merchant screen I want a button that can edit the schedule |
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/36295ce2-63da-4170-a171-ffa90bac9996 Co-authored-by: StuartFerguson <[email protected]>
Handled in c85fcc9. The view merchant screen now opens the schedule in read-only mode, and the edit merchant screen now has an Edit Schedule button that opens the editable schedule flow. I also added focused page coverage for the new navigation and read-only behavior. Screenshot: https://github.com/user-attachments/assets/2b835bf3-95f4-4073-b8e4-bad79f00aebd Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/a8d0b570-ab60-4042-95ec-a87783579ea2 Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/a8d0b570-ab60-4042-95ec-a87783579ea2 Co-authored-by: StuartFerguson <[email protected]>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 1 medium |
🟢 Metrics 47 complexity · 4 duplication
Metric Results Complexity 47 Duplication 4
TIP This summary will be updated as you push new changes. Give us feedback
|
@copilot tests still failing :( |
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/a4e71582-240e-4beb-9267-2496325f77d9 Co-authored-by: StuartFerguson <[email protected]>
Addressed in 3d1bb29. I made the merchant schedule page tests wait for the async year-load to complete before interacting with future-year month inputs, which removes the remaining CI timing failures. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/3f78701d-ef2f-4473-8835-bcb076d8726b Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/92485412-2eef-410d-9bfc-545e5407a8aa Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/5f47f67c-5220-4016-b805-e2acb6078dc0 Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/5f47f67c-5220-4016-b805-e2acb6078dc0 Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/fabc478b-6126-4e62-842b-aca154bfed8e Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/fabc478b-6126-4e62-842b-aca154bfed8e Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/EstateManagementUI/sessions/f3216be3-a393-45bd-84cc-f9bb8b144229 Co-authored-by: StuartFerguson <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.