do work on TODO's

SecurityService.UserInterface/Pages/Account/EmailConfirmation/Confirm.cshtml.cs

@@ -7,6 +7,7 @@
 using Microsoft.AspNetCore.Identity;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.AspNetCore.Mvc.RazorPages;
+using Shared.Logger;
 using SimpleResults;
 
 namespace IdentityServerHost.Pages.EmailConfirmation;
@@ -53,7 +54,8 @@ public async Task<IActionResult> OnGet(CancellationToken cancellationToken) {
             // Send the welcome email 
             SecurityServiceCommands.SendWelcomeEmailCommand command = new(Input.Username);
             Result? sendWelcomeEmailResult = await this.Mediator.Send(command, cancellationToken);
-            // TODO: handle this result....
+            if (sendWelcomeEmailResult.IsFailed)
+                Logger.LogWarning($"Error sending welcome email to {this.Input.Username} [{sendWelcomeEmailResult.Message}]");
 
         }
         return Page();

SecurityService.UserInterface/Pages/Account/ForgotPassword/Confirm.cshtml.cs

@@ -53,13 +53,21 @@ public async Task<IActionResult> OnPost(CancellationToken cancellationToken)
             return Redirect("Login/Index");
         }
 
-        // TODO: Check passwords match etc here
-
         if (ModelState.IsValid) {
             // process the password change
             SecurityServiceCommands.ProcessPasswordResetConfirmationCommand command = new(Input.Username, Input.Token, Input.Password, Input.ClientId);
             Result<String>? result= await this.Mediator.Send(command, cancellationToken);
-            // TODO: Failure case
+
+            if (result.IsFailed) {
+                this.View = new ViewModel
+                {
+                    Username = Input.Username,
+                    Token = Input.Token,
+                    UserMessage = $"Failed processing password reset for username {Input.Username}: {result.Message}"
+                };
+                return Page();
+            }
+
             return this.Redirect(result.Data);
         }
 

SecurityService.UserInterface/Pages/Device/Index.cshtml.cs

@@ -134,7 +134,7 @@
     }
 
 
     private async Task<ViewModel> BuildViewModelAsync(string userCode, InputModel model = null)
     {
         var request = await _interaction.GetAuthorizationContextAsync(userCode);
         if (request != null)
@@ -194,7 +194,6 @@
         return new ScopeViewModel
         {
             Value = parsedScopeValue.RawValue,
-            // todo: use the parsed scope value in the display?
             DisplayName = apiScope.DisplayName ?? apiScope.Name,
             Description = apiScope.Description,
             Emphasize = apiScope.Emphasize,

SecurityService/Common/SwaggerJsonConverter.cs

@@ -51,7 +51,8 @@ public override Object ReadJson(JsonReader reader,
                                         Object existingValue,
                                         JsonSerializer serializer)
         {
-            throw new NotImplementedException();
+            // Not used because CanRead returns false
+            return new Object();
         }
 
         /// <summary>

SecurityService/Controllers/ApiResourceController.cs

@@ -64,7 +64,7 @@ public async Task<IActionResult> CreateApiResource([FromBody] CreateApiResourceR
                 createApiResourceRequest.UserClaims);
 
             Result result = await this.Mediator.Send(command, cancellationToken);
-            // TODO: Handle failed result
+
             return result.ToActionResultX();
         }