fixes

SecurityService.Client/SecurityServiceClient.cs

@@ -368,7 +368,6 @@ public async Task<Result<ApiScopeDetails>> GetApiScope(String apiScopeName,
 
         public async Task<Result<List<ApiScopeDetails>>> GetApiScopes(CancellationToken cancellationToken)
         {
-            List<ApiScopeDetails> response = null;
             String requestUri = this.BuildRequestUrl("/api/apiscopes");
 
             try
@@ -434,7 +433,6 @@ public async Task<Result<ClientDetails>> GetClient(String clientId,
 
         public async Task<Result<List<ClientDetails>>> GetClients(CancellationToken cancellationToken)
         {
-            List<ClientDetails> response = null;
             String requestUri = this.BuildRequestUrl("/api/clients");
 
             try
@@ -569,7 +567,6 @@ public async Task<Result<RoleDetails>> GetRole(Guid roleId,
 
         public async Task<Result<List<RoleDetails>>> GetRoles(CancellationToken cancellationToken)
         {
-            List<RoleDetails> response = null;
             String requestUri = this.BuildRequestUrl("/api/roles");
 
             try
@@ -734,7 +731,6 @@ private async Task<Result<TokenResponse>> GetToken(String tokenRequest,
                                             CancellationToken cancellationToken)
         {
             String requestUri = this.BuildRequestUrl("/connect/token");
-            String content = null;
 
             try
             {

SecurityService.UserInterface/Pages/Account/ChangePassword/Index.cshtml.cs

@@ -47,9 +47,9 @@ public async Task<IActionResult> OnGet(String returnUrl)
         return Page();
     }
 
-    public const String PasswordsDontMatch = "New Password does not match Confirm Password";
+    private const String DontMatchMessage = "New Password does not match Confirm Password";
 
-    public const String ErrorChangingPassword = "An error occurred changing password";
+    private const String ErrorChangingMessage = "An error occurred changing password";
 
     public async Task<IActionResult> OnPost(CancellationToken cancellationToken) {
         await BuildModelAsync(Input.ReturnUrl);
@@ -60,15 +60,15 @@ public async Task<IActionResult> OnPost(CancellationToken cancellationToken) {
 
         if (String.CompareOrdinal(Input.NewPassword, Input.ConfirmPassword) != 0) {
             await BuildModelAsync(Input.ReturnUrl);
-            ModelState.AddModelError(String.Empty, PasswordsDontMatch);
+            ModelState.AddModelError(String.Empty, DontMatchMessage);
             return this.Page();
         }
 
         SecurityServiceCommands.ChangeUserPasswordCommand command = new(Input.Username, Input.CurrentPassword, Input.NewPassword, Input.ClientId);
         Result<ChangeUserPasswordResult>? result = await this.Mediator.Send(command, cancellationToken);
 
         if (result.IsFailed) {
-            ModelState.AddModelError(String.Empty, ErrorChangingPassword);
+            ModelState.AddModelError(String.Empty, ErrorChangingMessage);
             return this.Page();
         }
 

SecurityService.UserInterface/Pages/Index.cshtml.cs

@@ -9,9 +9,9 @@
 [AllowAnonymous]
 public class Index : PageModel
 {
-    public string Version;
+    public string Version { get; private set; }
 
     public void OnGet()
     {
         Version = typeof(Duende.IdentityServer.Hosting.IdentityServerMiddleware).Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion.Split('+').First();
     }