Reduce cyclomatic complexity of CreateConsentViewModel#1050
Merged
StuartFerguson merged 3 commits intomasterfrom Mar 9, 2026
Merged
Reduce cyclomatic complexity of CreateConsentViewModel#1050StuartFerguson merged 3 commits intomasterfrom
StuartFerguson merged 3 commits intomasterfrom
Conversation
…helper methods Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix cyclomatic complexity in CreateConsentViewModel method
Reduce cyclomatic complexity of CreateConsentViewModel
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateConsentViewModelinPages/Consent/Index.cshtml.cshad a cyclomatic complexity of 14 against a limit of 8, caused by inline null-conditional chains, logical operators, and a foreach/if combination all within a single method.Changes
GetIdentityScopes— isolates identity resource scope mappingGetApiScopes— isolates API scope mapping including resource indicators, parsed scope iteration, and offline access handlingIsScopeConsented— consolidates three separate inline consent-check expressions into a single reusable helper using the simplified pattern:CreateConsentViewModelnow delegates entirely to these helpers, reducing its complexity to ~1. Each extracted method stays well below the limit of 8.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
f.feedz.io/usr/bin/dotnet dotnet build SecurityService.UserInterface/SecurityService.UserInterface.csproj(dns block)/opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/SecurityService/SecurityService/SecurityService.sln --packages /tmp/codeql-scratch-89cd281515db216c/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-89cd281515db216c/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-89cd281515db216c/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.