Refactor client HTTP logic with new ClientBase class#1608
Merged
StuartFerguson merged 1 commit intomasterfrom May 3, 2026
Merged
Refactor client HTTP logic with new ClientBase class#1608StuartFerguson merged 1 commit intomasterfrom
StuartFerguson merged 1 commit intomasterfrom
Conversation
Introduce abstract ClientBase to centralize HTTP request logic, serialization, deserialization, and error handling. Refactor SecurityServiceClient to inherit from ClientBase, replacing custom HTTP methods with unified ClientBase methods. Switch to Newtonsoft.Json for (de)serialization and update all HTTP calls for consistency and maintainability.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 1 medium |
| CodeStyle | 1 minor |
| Complexity | 1 critical |
🟢 Metrics 94 complexity · 21 duplication
Metric Results Complexity 94 Duplication 21
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce abstract ClientBase to centralize HTTP request logic, serialization, deserialization, and error handling. Refactor SecurityServiceClient to inherit from ClientBase, replacing custom HTTP methods with unified ClientBase methods. Switch to Newtonsoft.Json for (de)serialization and update all HTTP calls for consistency and maintainability.