Skip to content

Update packages and migrate from Newtonsoft.Json to System.Text.Json #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 3 commits into from
May 6, 2026
Merged

Update packages and migrate from Newtonsoft.Json to System.Text.Json #1619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ef86e1
Update packages and migrate from Newtonsoft.Json to System.Text.Json
StuartFerguson May 6, 2026
1b8e932
:|
StuartFerguson May 6, 2026
712b6b2
:|
StuartFerguson May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SecurityService.BusinessLogic/SecurityService.BusinessLogic.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="MediatR" Version="14.1.0" />
<PackageReference Include="MessagingService.Client" Version="2026.3.2" />
<PackageReference Include="MessagingService.Client" Version="2026.4.3-build126" />
<PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="10.0.5" />
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="10.0.5" />
<PackageReference Include="OpenIddict.Abstractions" Version="7.3.0" />
<PackageReference Include="OpenIddict.Server" Version="7.3.0" />
<PackageReference Include="OpenIddict.Server.AspNetCore" Version="7.3.0" />
<PackageReference Include="OpenIddict.Validation.AspNetCore" Version="7.3.0" />
<PackageReference Include="Shared.Results" Version="2026.5.4" />
<PackageReference Include="Shared.Results" Version="2026.5.5" />
<PackageReference Include="SimpleResults" Version="4.0.0" />
</ItemGroup>
<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions SecurityService.Client/SecurityService.Client.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="ClientProxyBase" Version="2026.5.4" />
<PackageReference Include="Shared.Results" Version="2026.5.4" />
<PackageReference Include="ClientProxyBase" Version="2026.5.5" />
<PackageReference Include="Shared.Results" Version="2026.5.5" />
</ItemGroup>

<ItemGroup>
Expand Down
23 changes: 11 additions & 12 deletions SecurityService.DataTransferObjects/Responses.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
using Newtonsoft.Json;
using System.Text.Json.Serialization;

using System.Text.Json;

namespace SecurityService.DataTransferObjects;

public sealed class ApiResourceResponse {
public string Name { get; set; }

Check warning on line 7 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 7 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public string? DisplayName { get; set; }

public string? Description { get; set; }

public IReadOnlyCollection<string> Scopes { get; set; }

Check warning on line 13 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'Scopes' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 13 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'Scopes' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public IReadOnlyCollection<string> UserClaims { get; set; }

Check warning on line 15 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'UserClaims' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 15 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'UserClaims' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
}

public sealed record ApiScopeResponse {
public string Name { get; set; }

Check warning on line 19 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 19 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 19 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public string? DisplayName { get; set; }

Expand All @@ -24,15 +24,15 @@
}

public sealed record ClientResponse {
public string ClientId { get; set; }

Check warning on line 27 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'ClientId' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public string ClientName { get; set; }

Check warning on line 29 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'ClientName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public string? Description { get; set; }

public string? ClientUri { get; set; }

public IReadOnlyCollection<string> AllowedScopes { get; set; }

Check warning on line 35 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'AllowedScopes' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public IReadOnlyCollection<string> AllowedGrantTypes { get; set; }

Expand All @@ -49,7 +49,7 @@

public sealed record IdentityResourceResponse
{
public string Name { get; set; }

Check warning on line 52 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public string? DisplayName { get; set; }

Expand All @@ -61,20 +61,20 @@

public bool ShowInDiscoveryDocument { get; set; }

public IReadOnlyCollection<string> Claims { get; set; }

Check warning on line 64 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Non-nullable property 'Claims' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
}


public sealed record RoleResponse
{
public String RoleId { get; set; }

Check warning on line 70 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Non-nullable property 'RoleId' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 70 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Non-nullable property 'RoleId' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 70 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'RoleId' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 70 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'RoleId' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public string RoleName { get; set; }

Check warning on line 71 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Non-nullable property 'RoleName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 71 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Non-nullable property 'RoleName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
}

public sealed record UserResponse {
public String UserId { get; set; }

Check warning on line 75 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Non-nullable property 'UserId' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public string UserName { get; set; }

Check warning on line 77 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Non-nullable property 'UserName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public string? EmailAddress { get; set; }

Expand All @@ -86,9 +86,9 @@

public string? FamilyName { get; set; }

public IReadOnlyDictionary<string, string> Claims{ get; set; }

Check warning on line 89 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Non-nullable property 'Claims' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public IReadOnlyCollection<string> Roles { get; set; }

Check warning on line 91 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Non-nullable property 'Roles' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

public DateTime RegistrationDateTime { get; set; }
}
Expand All @@ -100,24 +100,23 @@
public Int64 ExpiresIn { get; private set; }
public DateTimeOffset Issued { get; private set; }
public String RefreshToken { get; private set; }
public static TokenResponse Create(String token)
{
dynamic auth = JsonConvert.DeserializeObject(token);
public static TokenResponse Create(String token) {
using var doc = JsonDocument.Parse(token);
var root = doc.RootElement;

Int64 expiresIn = auth["expires_in"].Value;
String accessToken = auth["access_token"].Value;
long expiresIn = root.GetProperty("expires_in").GetInt64();
string accessToken = root.GetProperty("access_token").GetString();

Check warning on line 108 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Converting null literal or possible null value to non-nullable type.

Check warning on line 108 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Converting null literal or possible null value to non-nullable type.

Check warning on line 108 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Converting null literal or possible null value to non-nullable type.

DateTimeOffset issued = DateTimeOffset.Now;
DateTimeOffset expires = DateTimeOffset.Now.AddSeconds(expiresIn);
DateTimeOffset expires = issued.AddSeconds(expiresIn);

String refreshToken = null;
//For client credentials, the refresh_token will not be present
if (auth["refresh_token"] != null)
string refreshToken = null;

Check warning on line 113 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Converting null literal or possible null value to non-nullable type.

Check warning on line 113 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Converting null literal or possible null value to non-nullable type.

Check warning on line 113 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Converting null literal or possible null value to non-nullable type.
if (root.TryGetProperty("refresh_token", out var refreshElement))
{
refreshToken = auth["refresh_token"].Value;
refreshToken = refreshElement.GetString();

Check warning on line 116 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Converting null literal or possible null value to non-nullable type.

Check warning on line 116 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Converting null literal or possible null value to non-nullable type.

Check warning on line 116 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Converting null literal or possible null value to non-nullable type.
}

return TokenResponse.Create(accessToken, refreshToken, expiresIn, issued, expires);

Check warning on line 119 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Possible null reference argument for parameter 'refreshToken' in 'TokenResponse TokenResponse.Create(string accessToken, string refreshToken, long expiresIn, DateTimeOffset issued = default(DateTimeOffset), DateTimeOffset expires = default(DateTimeOffset))'.

Check warning on line 119 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Possible null reference argument for parameter 'accessToken' in 'TokenResponse TokenResponse.Create(string accessToken, string refreshToken, long expiresIn, DateTimeOffset issued = default(DateTimeOffset), DateTimeOffset expires = default(DateTimeOffset))'.

Check warning on line 119 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Possible null reference argument for parameter 'refreshToken' in 'TokenResponse TokenResponse.Create(string accessToken, string refreshToken, long expiresIn, DateTimeOffset issued = default(DateTimeOffset), DateTimeOffset expires = default(DateTimeOffset))'.

Check warning on line 119 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Chrome UI 

Possible null reference argument for parameter 'accessToken' in 'TokenResponse TokenResponse.Create(string accessToken, string refreshToken, long expiresIn, DateTimeOffset issued = default(DateTimeOffset), DateTimeOffset expires = default(DateTimeOffset))'.

Check warning on line 119 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Possible null reference argument for parameter 'refreshToken' in 'TokenResponse TokenResponse.Create(string accessToken, string refreshToken, long expiresIn, DateTimeOffset issued = default(DateTimeOffset), DateTimeOffset expires = default(DateTimeOffset))'.

Check warning on line 119 in SecurityService.DataTransferObjects/Responses.cs

View workflow job for this annotation

GitHub Actions / Build and Unit Test Pull Requests - Edge UI 

Possible null reference argument for parameter 'accessToken' in 'TokenResponse TokenResponse.Create(string accessToken, string refreshToken, long expiresIn, DateTimeOffset issued = default(DateTimeOffset), DateTimeOffset expires = default(DateTimeOffset))'.
}

public static TokenResponse Create(String accessToken,
Expand Down
2 changes: 1 addition & 1 deletion SecurityService.DataTransferObjects/SecurityService.DataTransferObjects.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />

</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion SecurityService.IntegrationTesting.Helpers/SecurityService.IntegrationTesting.Helpers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="10.0.3" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="10.0.5" />
<PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="10.0.5" />
<PackageReference Include="Shared.IntegrationTesting" Version="2026.5.4" />
<PackageReference Include="Shared.IntegrationTesting" Version="2026.5.5" />
</ItemGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion SecurityService.IntegrationTests/ApiResource/ApiResourceSteps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ namespace SecurityService.IntegrationTests.ApiResource
using Clients;
using IntegrationTesting.Helpers;
using IntergrationTests.Common;
using Newtonsoft.Json;
using Reqnroll;
using Shouldly;

Expand Down
2 changes: 1 addition & 1 deletion SecurityService.IntegrationTests/SecurityService.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<PackageReference Include="NUnit3TestAdapter" Version="6.1.0" />
<PackageReference Include="Reqnroll.NUnit" Version="3.3.3" />

<PackageReference Include="Shared.IntegrationTesting" Version="2026.5.4" />
<PackageReference Include="Shared.IntegrationTesting" Version="2026.5.5" />
<PackageReference Include="System.Data.SqlClient" Version="4.9.1" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="10.0.5" />

Expand Down
1 change: 0 additions & 1 deletion SecurityService.IntegrationTests/Users/UsersSteps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
using Common;
using DataTransferObjects;
using IntegrationTesting.Helpers;
using Newtonsoft.Json;
using Reqnroll;
using Shouldly;

Expand Down
6 changes: 3 additions & 3 deletions SecurityService.OpenIdConnect.IntegrationTests/Common/DockerHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
using DotNet.Testcontainers.Networks;
using Shared.IntegrationTesting.TestContainers;
using System.Runtime.InteropServices;
using System.Text.Json;

namespace SecurityService.IntergrationTests.Common
{
using Client;
using Newtonsoft.Json;
using Shared.HealthChecks;
using Shared.IntegrationTesting;
using Shared.Logger;
Expand Down Expand Up @@ -57,7 +57,7 @@ public class DockerHelper : Shared.IntegrationTesting.TestContainers.DockerHelpe
/// <param name="logger">The logger.</param>
public DockerHelper() : base()
{

StringSerialiser.Initialise(new SystemTextJsonSerializer(SystemTextJsonSerializer.GetDefaultJsonSerializerOptions()));
}

#endregion
Expand Down Expand Up @@ -119,7 +119,7 @@ await Retry.For(async () => {
await this.HealthCheckClient.PerformHealthCheck("https", "127.0.0.1", this.SecurityServiceTestUIPort, CancellationToken.None);

healthCheck.IsSuccess.ShouldBeTrue($"Health check for Test UI failed with [{healthCheck.Message}]");
HealthCheckResult result = JsonConvert.DeserializeObject<HealthCheckResult>(healthCheck.Data);
HealthCheckResult result = StringSerialiser.Deserialise<HealthCheckResult>(healthCheck.Data);

this.Trace($"health check complete for Test UI result is [{healthCheck}]");

Expand Down
4 changes: 2 additions & 2 deletions SecurityService.OpenIdConnect.IntegrationTests/ForgotPassword/ForgotPasswordSteps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using Shared.Serialisation;

namespace SecurityService.OpenIdConnect.IntegrationTests.ForgotPassword
{
Expand All @@ -11,7 +12,6 @@ namespace SecurityService.OpenIdConnect.IntegrationTests.ForgotPassword
using System.Threading;
using HtmlAgilityPack;
using IntergrationTests.Common;
using Newtonsoft.Json;
using OpenQA.Selenium;
using Reqnroll;
using SecurityService.IntegrationTests.UserLogin;
Expand Down Expand Up @@ -87,7 +87,7 @@ public async Task ThenIGetAnEmailWithAForgotPasswordLink() {
MessageId = Guid.Empty,
Body = String.Empty
};
var x = JsonConvert.DeserializeAnonymousType(await response.Content.ReadAsStringAsync(CancellationToken.None), emailMessage);
var x = StringSerialiser.DeserialiseAnonymousType(await response.Content.ReadAsStringAsync(CancellationToken.None), emailMessage);

var doc = new HtmlDocument();
doc.LoadHtml(x.Body);
Expand Down
2 changes: 1 addition & 1 deletion ...vice.OpenIdConnect.IntegrationTests/SecurityService.OpenIdConnect.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

<PackageReference Include="Selenium.Support" Version="4.41.0" />
<PackageReference Include="Selenium.WebDriver" Version="4.41.0" />
<PackageReference Include="Shared.IntegrationTesting" Version="2026.5.4" />
<PackageReference Include="Shared.IntegrationTesting" Version="2026.5.5" />
<PackageReference Include="coverlet.collector" Version="8.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
6 changes: 3 additions & 3 deletions SecurityService.OpenIdConnect.IntegrationTests/UserLogin/UserLoginSteps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using Shared.Serialisation;

namespace SecurityService.IntegrationTests.UserLogin
{
Expand All @@ -12,7 +13,6 @@ namespace SecurityService.IntegrationTests.UserLogin
using System.Threading.Tasks;
using HtmlAgilityPack;
using IntergrationTests.Common;
using Newtonsoft.Json;
using OpenQA.Selenium;
using Reqnroll;
using Shared.IntegrationTesting;
Expand Down Expand Up @@ -112,7 +112,7 @@ public async Task ThenIGetAnEmailWithAConfirmEmailAddressLink()
MessageId = Guid.Empty,
Body = String.Empty
};
var x = JsonConvert.DeserializeAnonymousType(await response.Content.ReadAsStringAsync(CancellationToken.None), emailMessage);
var x = StringSerialiser.DeserialiseAnonymousType(await response.Content.ReadAsStringAsync(CancellationToken.None), emailMessage);

HtmlDocument doc = new HtmlDocument();
doc.LoadHtml(x.Body);
Expand Down Expand Up @@ -140,7 +140,7 @@ public async Task ThenIGetAWelcomeEmailWithMyLoginDetails()
MessageId = Guid.Empty,
Body = String.Empty
};
var x = JsonConvert.DeserializeAnonymousType(await response.Content.ReadAsStringAsync(CancellationToken.None), emailMessage);
var x = StringSerialiser.DeserialiseAnonymousType(await response.Content.ReadAsStringAsync(CancellationToken.None), emailMessage);

HtmlDocument doc = new HtmlDocument();
doc.LoadHtml(x.Body);
Expand Down
5 changes: 2 additions & 3 deletions SecurityService/SecurityService.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
<PackageReference Include="MediatR" Version="14.1.0" />
<PackageReference Include="Microsoft.AspNetCore.Authentication.OpenIdConnect" Version="10.0.5" />
<PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="10.0.5" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="10.0.5" />
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="10.0.5" />
<PackageReference Include="Microsoft.Extensions.Hosting.WindowsServices" Version="10.0.5" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="10.0.5">
Expand All @@ -33,8 +32,8 @@
<PackageReference Include="OpenIddict.EntityFrameworkCore" Version="7.3.0" />
<PackageReference Include="OpenIddict.Server.AspNetCore" Version="7.3.0" />
<PackageReference Include="OpenIddict.Validation.AspNetCore" Version="7.3.0" />
<PackageReference Include="Shared" Version="2026.5.4" />
<PackageReference Include="Shared.Results.Web" Version="2026.5.4" />
<PackageReference Include="Shared" Version="2026.5.5" />
<PackageReference Include="Shared.Results.Web" Version="2026.5.5" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="10.0.1" />
<PackageReference Include="Sentry.AspNetCore" Version="6.2.0" />
<PackageReference Include="NLog.Web.AspNetCore" Version="6.1.2" />
Expand Down
2 changes: 1 addition & 1 deletion SecurityServiceTestUI/SecurityServiceTestUI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<PackageReference Include="Microsoft.AspNetCore.Authentication.OpenIdConnect" Version="10.0.3" />
<PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="10.0.3" />
<PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.23.0" />
<PackageReference Include="Shared" Version="2026.5.4" />
<PackageReference Include="Shared" Version="2026.5.5" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading