Update package versions and implement Result<T> pattern#690
Merged
StuartFerguson merged 1 commit intomasterfrom May 27, 2025
Merged
Update package versions and implement Result<T> pattern#690StuartFerguson merged 1 commit intomasterfrom
StuartFerguson merged 1 commit intomasterfrom
Conversation
- Updated `Shared`, `Shared.Results`, and `Shared.IntegrationTesting` package references to version `2025.5.4`. - Refactored `SecurityServiceSteps` to use `Result<T>` for improved error handling and type safety. - Enhanced result handling in controllers (`ApiResourceController`, `ApiScopeController`, `ClientController`, `IdentityResourceController`, `RoleController`, `UserController`) to check operation success. - Added `Shared.Results.Web` package reference to `SecurityService.csproj`. - Updated health check logic in `DockerHelper.cs` to align with new result handling. - Included `using SimpleResults;` in multiple files to support new result types. - Adjusted `SecurityServiceTestUI.csproj` for updated package version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared,Shared.Results, andShared.IntegrationTestingpackage references to version2025.5.4.SecurityServiceStepsto useResult<T>for improved error handling and type safety.ApiResourceController,ApiScopeController,ClientController,IdentityResourceController,RoleController,UserController) to check operation success.Shared.Results.Webpackage reference toSecurityService.csproj.DockerHelper.csto align with new result handling.using SimpleResults;in multiple files to support new result types.SecurityServiceTestUI.csprojfor updated package version.Closes Upgrade Simple Results version #688