Skip to content

fix the end to end pr failure #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 3 commits into from
May 27, 2025
Merged

fix the end to end pr failure #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
022f5ab
fix the end to end pr failure
StuartFerguson May 27, 2025
1e5ae60
Prevent duplicate logger initialization
StuartFerguson May 27, 2025
ff5f2c1
Merge branch 'main' into task/#195_improve_test_coverage
StuartFerguson May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions TransactionMobile.Maui.BusinessLogic/Logging/Logger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ public static void Initialise(ILogger loggerObject)
if (Logger.LoggerObjects == null) {
Logger.LoggerObjects = new List<ILogger>();
}

if (Logger.LoggerObjects.Any(l => l.GetType() == loggerObject.GetType())) {
// Already initialised
return;
}
Logger.LoggerObjects.Add(loggerObject);

Logger.IsInitialised = true;
Expand Down
2 changes: 1 addition & 1 deletion TransactionMobile.Maui.BusinessLogic/TransactionMobile.Maui.BusinessLogic.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="8.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Refractored.MvvmHelpers" Version="1.6.2" />
<PackageReference Include="SecurityService.Client" Version="2025.1.1" />
<PackageReference Include="SecurityService.Client" Version="2025.5.1" />
<PackageReference Include="SimpleResults" Version="4.0.0" />
<PackageReference Include="TransactionProcessorACL.DataTransferObjects" Version="2025.3.1" />
<PackageReference Include="sqlite-net-pcl" Version="1.9.172" />
Expand Down
2 changes: 1 addition & 1 deletion TransactionMobile.Maui.UiTests/Features/EndToEndTests.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ Background:

Given I have created a config for my device

@PRTest @ignore
@PRTest
Scenario: EndToEnd
Given I am on the Login Screen
And my device is registered
Expand Down
4 changes: 2 additions & 2 deletions TransactionMobile.Maui.UiTests/TransactionMobile.Maui.UiTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
<PackageReference Include="NUnit3TestAdapter" Version="5.0.0" />
<PackageReference Include="Reqnroll.NUnit" Version="2.4.0" />
<PackageReference Include="Reqnroll.Tools.MsBuild.Generation" Version="2.4.0" />
<PackageReference Include="SecurityService.Client" Version="2025.3.1" />
<PackageReference Include="SecurityService.IntegrationTesting.Helpers" Version="2025.3.1" />
<PackageReference Include="SecurityService.Client" Version="2025.5.1" />
<PackageReference Include="SecurityService.IntegrationTesting.Helpers" Version="2025.5.1" />
<PackageReference Include="TransactionProcessor.Client" Version="2025.5.1" />
<PackageReference Include="EventStoreProjections" Version="2023.12.3" />
<PackageReference Include="Appium.WebDriver" Version="7.2.0" />
Expand Down
Loading