Fix AutomationId placement on SalesAnalysis page header#462
Fix AutomationId placement on SalesAnalysis page header#462
Conversation
…id layouts Co-authored-by: StuartFerguson <[email protected]>
|
@copilot layout looking good, can this be taken to the other screens in the transaction flows and also the my account screens |
…alysis pages Co-authored-by: StuartFerguson <[email protected]>
Done in commit My Account screens:
Reports screens:
Every page in the app now uses the consistent |
|
@copilot can you make the buttons into tiles on these screens as well |
…ports and support screens Co-authored-by: StuartFerguson <[email protected]>
Done in commit Transaction flows — dynamic selection pages (code-behind updated to build
Transaction flows — form & result pages (XAML updated):
My Account screens:
Support + other screens:
A new |
|
@copilot got 3 build errors 'MobileTopupPerformTopupPage' does not contain a definition for 'PerformTopupButton' and no accessible extension method 'PerformTopupButton' accepting a first argument of type 'MobileTopupPerformTopupPage' could be found (are you missing a using directive or an assembly reference?) 'BillPaymentPayBillPage' does not contain a definition for 'MakePaymentButton' and no accessible extension method 'MakePaymentButton' accepting a first argument of type 'BillPaymentPayBillPage' could be found (are you missing a using directive or an assembly reference?) |
… elements Co-authored-by: StuartFerguson <[email protected]>
Fixed in commit
|
|
@copilot does that not stop the code from working ? |
No, it doesn't break anything. Those callbacks only moved keyboard focus to the submit button after the user finished typing in the last form field — a minor UX convenience so pressing Return on the keyboard would activate the button. The tile |
|
@copilot can the my account and reports screens not have the 4 tiles like other screens, same with the operator and product selection screens if you can |
… pages to 2-column tile grid Co-authored-by: StuartFerguson <[email protected]>
Done in commit My Account — options (Account Details, Addresses, Contact) appear as 100px tiles, two per row, with the Back tile spanning full width below. Reports — report options appear as 100px tiles, two per row, with Back spanning full width below. Operator & product selection (Mobile Topup, Bill Payment, Voucher) — operator names and product names fill the grid two-per-row; the Back tile is always full-width at the bottom. The Security summary: No security-relevant changes were made. The CodeQL scan timed out (MAUI workload not available in sandbox), but the changes are purely UI layout — no data handling, authentication, or network code was touched. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…not-found on Android Co-authored-by: StuartFerguson <[email protected]>
…nt-not-found on Android Co-authored-by: StuartFerguson <[email protected]>
…ages Co-authored-by: StuartFerguson <[email protected]>
…or UIAutomator2 reliability; fix operator/product tile IDs with .Replace spaces Co-authored-by: StuartFerguson <[email protected]>
…ator2 can find it Co-authored-by: StuartFerguson <[email protected]>
…xaml Co-authored-by: StuartFerguson <[email protected]>
UI automation tests for
SalesAnalysisPagewere failing becauseAutomationId="SalesAnalysis"was placed on the headerFrameinstead of theLabelinside it — the element the Appium accessibility ID lookup actually resolves.Change
Moved
AutomationIdfromFrametoLabel, consistent with every other page in the codebase:Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.