Skip to content

Add persisted dark theme support from My Account#483

Merged
StuartFerguson merged 16 commits into
mainfrom
copilot/add-dark-theme-option
Apr 2, 2026
Merged

Add persisted dark theme support from My Account#483
StuartFerguson merged 16 commits into
mainfrom
copilot/add-dark-theme-option

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

  • Inspect the current sales analysis theme and page styling
  • Run the existing test/build commands to capture the current baseline failures
  • Replace sales analysis card and text colors with explicit theme-aware bindings
  • Re-run targeted validation and push the fix

Copilot AI linked an issue Apr 1, 2026 that may be closed by this pull request
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 1, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 16 complexity · -1 duplication

Metric Results
Complexity 16
Duplication -1

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Copilot AI changed the title [WIP] Add option for dark theme configuration Add persisted dark theme support from My Account Apr 1, 2026
Copilot AI requested a review from StuartFerguson April 1, 2026 10:31
@StuartFerguson
Copy link
Copy Markdown
Member

@copilot pulled down the code and got a build error

Cannot implicitly convert type 'System.Collections.Generic.ICollection<Microsoft.Maui.Controls.ResourceDictionary>' to 'System.Collections.Generic.IList<Microsoft.Maui.Controls.ResourceDictionary>'. An explicit conversion exists (are you missing a cast?)

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 1, 2026

@copilot pulled down the code and got a build error

Cannot implicitly convert type 'System.Collections.Generic.ICollection<Microsoft.Maui.Controls.ResourceDictionary>' to 'System.Collections.Generi...

Fixed in e61efa9. I updated the theme dictionary replacement logic to use the MergedDictionaries collection type that MAUI exposes, while preserving theme dictionary order. Screenshot: https://github.com/user-attachments/assets/dae8d1f0-2cf3-45e6-b318-eaec1ac23e4e

@StuartFerguson
Copy link
Copy Markdown
Member

@copilot one final thick can the images on the buttons in dark mode be made white

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 1, 2026

@copilot one final thick can the images on the buttons in dark mode be made white

Done in 00948d6. I switched the button/tile icons to white dark-mode SVG variants and wired the themed sources so they render correctly across the account, support, reports, and transaction screens. Screenshot: https://github.com/user-attachments/assets/79d57563-4ce9-475f-8372-79702cf70fb4

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • f.feedz.io
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)
  • learn.microsoft.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@StuartFerguson
Copy link
Copy Markdown
Member

@copilot can you look at the codacy issue and fix

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 1, 2026

@copilot can you look at the codacy issue and fix

Fixed in 7470884. I addressed the Codacy issue in the reports viewmodels by guarding the null SelectedItem path before reading DisplayText, removed the unused mediator dependencies from the affected report viewmodels/tests, and added a regression test for the null-selection case. Local restore/test is still blocked in this sandbox by the private Feedz source returning NU1301.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • f.feedz.io
    • Triggering command: /usr/bin/dotnet dotnet restore /home/REDACTED/work/TransactionMobile/TransactionMobile/TransactionProcessor.Mobile.BusinessLogic.Tests/TransactionProcessor.Mobile.BusinessLogic.Tests.csproj --configfile /home/REDACTED/work/TransactionMobile/TransactionMobile/Nuget.config (dns block)
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@StuartFerguson StuartFerguson marked this pull request as ready for review April 1, 2026 19:34
@StuartFerguson
Copy link
Copy Markdown
Member

@copilot have a look at this issue

Method ApplicationThemeService::ApplyTheme has a cyclomatic complexity of 9 (limit is 8)

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 1, 2026

@copilot have a look at this issue

Method ApplicationThemeService::ApplyTheme has a cyclomatic complexity of 9 (limit is 8)
...

Fixed in 7cace5b. I reduced ApplicationThemeService.ApplyTheme complexity by extracting the theme-dictionary replacement branch into a helper, without changing the theme selection behavior. No UI changed in this refactor, so there isn’t a screenshot to add.

@StuartFerguson
Copy link
Copy Markdown
Member

@copilot can you have a quick look at my test failure, says it cant find a label on the screen "DeviceSerial"

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 2, 2026

@copilot can you have a quick look at my test failure, says it cant find a label on the screen "DeviceSerial"

Fixed in 9d34140. I checked the failing Android Actions run and the app still has the DeviceSerial control, but Appium was getting 404s because it was off-screen in the scroll view. I updated the Android locator helper to scroll UiScrollable containers into view before failing, which should cover DeviceSerial and similar login-page elements.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • f.feedz.io
    • Triggering command: /usr/bin/dotnet dotnet build /home/REDACTED/work/TransactionMobile/TransactionMobile/TransactionProcessor.Mobile.UITests/TransactionProcessor.Mobile.UITests.csproj --configfile /home/REDACTED/work/TransactionMobile/TransactionMobile/Nuget.config (dns block)
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 16 complexity · -1 duplication

Metric Results
Complexity 16
Duplication -1

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@StuartFerguson StuartFerguson merged commit 706a712 into main Apr 2, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark Theme

2 participants