Add persisted dark theme support from My Account#483
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 16 |
| Duplication | -1 |
TIP This summary will be updated as you push new changes. Give us feedback
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/69a37858-a158-4559-8c34-b2ef103ca511 Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/69a37858-a158-4559-8c34-b2ef103ca511 Co-authored-by: StuartFerguson <[email protected]>
|
@copilot pulled down the code and got a build error Cannot implicitly convert type 'System.Collections.Generic.ICollection<Microsoft.Maui.Controls.ResourceDictionary>' to 'System.Collections.Generic.IList<Microsoft.Maui.Controls.ResourceDictionary>'. An explicit conversion exists (are you missing a cast?) |
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/0a3ce5b4-54b1-46cc-975b-8bb12842a09a Co-authored-by: StuartFerguson <[email protected]>
Fixed in e61efa9. I updated the theme dictionary replacement logic to use the |
|
@copilot one final thick can the images on the buttons in dark mode be made white |
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/7483231e-3678-4592-9c16-cf991c3a1788 Co-authored-by: StuartFerguson <[email protected]>
Done in 00948d6. I switched the button/tile icons to white dark-mode SVG variants and wired the themed sources so they render correctly across the account, support, reports, and transaction screens. Screenshot: https://github.com/user-attachments/assets/79d57563-4ce9-475f-8372-79702cf70fb4 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/4395961c-1b43-4c38-9da0-6e42f888e508 Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/0bc12220-15b9-4677-a01d-b597df0f923a Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/d0e00a6b-13ed-4533-89b1-a23403fc4fb3 Co-authored-by: StuartFerguson <[email protected]>
|
@copilot can you look at the codacy issue and fix |
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/43b73bc4-ebbb-4e7f-8d46-63939df7944d Co-authored-by: StuartFerguson <[email protected]>
Fixed in 7470884. I addressed the Codacy issue in the reports viewmodels by guarding the null Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot have a look at this issue Method ApplicationThemeService::ApplyTheme has a cyclomatic complexity of 9 (limit is 8) |
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/811e5f13-30d4-4f35-8ab0-4661ca6d0ba6 Co-authored-by: StuartFerguson <[email protected]>
Fixed in 7cace5b. I reduced |
|
@copilot can you have a quick look at my test failure, says it cant find a label on the screen "DeviceSerial" |
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/ba5f304b-452e-41af-a4e7-4f0044768195 Co-authored-by: StuartFerguson <[email protected]>
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/ba5f304b-452e-41af-a4e7-4f0044768195 Co-authored-by: StuartFerguson <[email protected]>
Fixed in 9d34140. I checked the failing Android Actions run and the app still has the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 16 |
| Duplication | -1 |
TIP This summary will be updated as you push new changes. Give us feedback
Uh oh!
There was an error while loading. Please reload this page.