Skip to content

Refactor training contract product creation logic #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Apr 6, 2026
Merged

Refactor training contract product creation logic #527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 61 additions & 99 deletions ...onProcessor.Mobile.BusinessLogic/Services/TrainingModeServices/TrainingMerchantService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,106 +7,68 @@ namespace TransactionProcessor.Mobile.BusinessLogic.Services.TrainingModeService
[ExcludeFromCodeCoverage]
public class TrainingMerchantService : IMerchantService
{
private record Contract(Guid ContractId, Guid OperatorId, string OperatorIdentfier, string OperatorName);

private readonly Contract Hospital1Contract = new(Guid.Parse("21DA6AC5-70E6-478E-A5E9-74C9B27F5725"), Guid.Parse("2CA5F4C7-34EC-425B-BB53-7EEDF48D9967"), "Hospital 1 Contract", "Hospital 1 Contract");
private readonly Contract SafaricomContract = new(Guid.Parse("D57DAC9B-4039-4120-B5A8-F7FDF1D3A3C2"), Guid.Parse("2CA5F4C7-34EC-425B-BB53-7EEDF48D9967"), "Safaricom", "Safaricom");
private readonly Contract PataPawaPostPayContract = new(Guid.Parse("0615E7F6-2749-4507-8588-E019E8110C95"), Guid.Parse("C485F21B-EF17-448D-8B8C-E217A07C1863"), "PataPawaPostPay", "PataPawaPostPay");
private readonly Contract PataPawaPrePayContract = new(Guid.Parse("7AAFFE8D-4EA2-485F-8600-D4D29A0043F0"), Guid.Parse("C485F21B-EF17-448D-8B8C-E217A07C1863"), "PataPawaPrePay", "PataPawaPrePay");

private static ContractProductModel CreateContractProductModel(Contract contract, string productDisplayText, Guid productId, ProductType productType, decimal? value = null) {
ContractProductModel product = new() {
ContractId = contract.ContractId,
IsFixedValue = value.HasValue,
OperatorId = contract.OperatorId,
OperatorIdentfier = contract.OperatorIdentfier,
OperatorName = contract.OperatorName,
ProductDisplayText = productDisplayText,
ProductId = productId,
ProductType = productType,
};
if (value.HasValue) {
product.Value = value.Value;
}

return product;
}

private List<ContractProductModel> GetVoucherProducts() {
List<ContractProductModel> products = new();

products.Add(CreateContractProductModel(Hospital1Contract, "10 KES", Guid.Parse("CBF55D95-306A-4E85-B367-24FA442998F6"), ProductType.Voucher, 10));
products.Add(CreateContractProductModel(Hospital1Contract, "20 KES", Guid.Parse("F5F9B63F-9F68-45E8-960B-CE0FC15ED672"), ProductType.Voucher, 20));
products.Add(CreateContractProductModel(Hospital1Contract, "Custom", Guid.Parse("268CBAF5-95E0-4D4C-9725-3BB2B76E4273"), ProductType.Voucher));

return products;
}

private List<ContractProductModel> GetTopupProducts() {
List<ContractProductModel> products = new();
products.Add(CreateContractProductModel(SafaricomContract, "100 KES", Guid.Parse("48D96AE5-A829-498B-8C0D-D7107610EBDC"), ProductType.MobileTopup, 100));
products.Add(CreateContractProductModel(SafaricomContract, "200 KES", Guid.Parse("63821A48-D35E-451D-9E88-C8DCB548E7ED"), ProductType.MobileTopup, 200));
products.Add(CreateContractProductModel(SafaricomContract, "Custom", Guid.Parse("63821A48-D35E-451D-9E88-C8DCB548E7ED"), ProductType.MobileTopup));

return products;
}

private List<ContractProductModel> GetBillPaymentProducts() {
List<ContractProductModel> products = new();

products.Add(CreateContractProductModel(PataPawaPostPayContract, "Bill Pay (Post)", Guid.Parse("DE92018C-513E-44B2-B96D-F5B3621C48A2"), ProductType.BillPayment));
products.Add(CreateContractProductModel(PataPawaPrePayContract, "Bill Pay (Pre)", Guid.Parse("A7472650-4420-43BF-8132-3A094EB084FE"), ProductType.BillPayment));

return products;
}


public async Task<Result<List<ContractProductModel>>> GetContractProducts(CancellationToken cancellationToken) {
return Result.Success(new List<ContractProductModel> {
new ContractProductModel {
ContractId = Guid.Parse("21DA6AC5-70E6-478E-A5E9-74C9B27F5725"),
IsFixedValue = true,
OperatorId = Guid.Parse("2CA5F4C7-34EC-425B-BB53-7EEDF48D9967"),
OperatorIdentfier = "Hospital 1 Contract",
OperatorName = "Hospital 1 Contract",
ProductDisplayText = "10 KES",
ProductId = Guid.Parse("CBF55D95-306A-4E85-B367-24FA442998F6"),
ProductType = ProductType.Voucher,
Value = 10
},
new ContractProductModel {
ContractId = Guid.Parse("21DA6AC5-70E6-478E-A5E9-74C9B27F5725"),
IsFixedValue = true,
OperatorId = Guid.Parse("2CA5F4C7-34EC-425B-BB53-7EEDF48D9967"),
OperatorIdentfier = "Hospital 1 Contract",
OperatorName = "Hospital 1 Contract",
ProductDisplayText = "20 KES",
ProductId = Guid.Parse("F5F9B63F-9F68-45E8-960B-CE0FC15ED672"),
ProductType = ProductType.Voucher,
Value = 20
},
new ContractProductModel {
ContractId = Guid.Parse("21DA6AC5-70E6-478E-A5E9-74C9B27F5725"),
IsFixedValue = false,
OperatorId = Guid.Parse("2CA5F4C7-34EC-425B-BB53-7EEDF48D9967"),
OperatorIdentfier = "Hospital 1 Contract",
OperatorName = "Hospital 1 Contract",
ProductDisplayText = "Custom",
ProductId = Guid.Parse("268CBAF5-95E0-4D4C-9725-3BB2B76E4273"),
ProductType = ProductType.Voucher
},
new ContractProductModel {
ContractId = Guid.Parse("D57DAC9B-4039-4120-B5A8-F7FDF1D3A3C2"),
IsFixedValue = true,
OperatorId = Guid.Parse("2CA5F4C7-34EC-425B-BB53-7EEDF48D9967"),
OperatorIdentfier = "Safaricom",
OperatorName = "Safaricom",
ProductDisplayText = "100 KES",
ProductId = Guid.Parse("48D96AE5-A829-498B-8C0D-D7107610EBDC"),
ProductType = ProductType.MobileTopup,
Value = 100
},
new ContractProductModel {
ContractId = Guid.Parse("D57DAC9B-4039-4120-B5A8-F7FDF1D3A3C2"),
IsFixedValue = true,
OperatorId = Guid.Parse("2CA5F4C7-34EC-425B-BB53-7EEDF48D9967"),
OperatorIdentfier = "Safaricom",
OperatorName = "Safaricom",
ProductDisplayText = "200 KES",
ProductId = Guid.Parse("63821A48-D35E-451D-9E88-C8DCB548E7ED"),
ProductType = ProductType.MobileTopup,
Value = 200
},
new ContractProductModel {
ContractId = Guid.Parse("D57DAC9B-4039-4120-B5A8-F7FDF1D3A3C2"),
IsFixedValue = false,
OperatorId = Guid.Parse("2CA5F4C7-34EC-425B-BB53-7EEDF48D9967"),
OperatorIdentfier = "Safaricom",
OperatorName = "Safaricom",
ProductDisplayText = "Custom",
ProductId = Guid.Parse("63821A48-D35E-451D-9E88-C8DCB548E7ED"),
ProductType = ProductType.MobileTopup
},
new ContractProductModel {
ContractId = Guid.Parse("D57DAC9B-4039-4120-B5A8-F7FDF1D3A3C2"),
IsFixedValue = false,
OperatorId = Guid.Parse("1CA5F4C7-34EC-425B-BB53-7EEDF48D9968"),
OperatorIdentfier = "Safaricom1",
OperatorName = "Safaricom1",
ProductDisplayText = "Custom",
ProductId = Guid.Parse("63821A48-D35E-451D-9E88-C8DCB548E7ED"),
ProductType = ProductType.MobileTopup
},
new ContractProductModel {
ContractId = Guid.Parse("0615E7F6-2749-4507-8588-E019E8110C95"),
IsFixedValue = false,
OperatorId = Guid.Parse("C485F21B-EF17-448D-8B8C-E217A07C1863"),
OperatorIdentfier = "PataPawaPostPay",
OperatorName = "Pata Pawa PostPay",
ProductDisplayText = "Bill Pay (Post)",
ProductId = Guid.Parse("DE92018C-513E-44B2-B96D-F5B3621C48A2"),
ProductType = ProductType.BillPayment,
ProductSubType = ProductSubType.BillPaymentPostPay
},
new ContractProductModel {
ContractId = Guid.Parse("7AAFFE8D-4EA2-485F-8600-D4D29A0043F0"),
IsFixedValue = false,
OperatorId = Guid.Parse("C485F21B-EF17-448D-8B8C-E217A07C1863"),
OperatorIdentfier = "PataPawaPrePay",
OperatorName = "Pata Pawa PrePay",
ProductDisplayText = "Bill Pay (Pre)",
ProductId = Guid.Parse("A7472650-4420-43BF-8132-3A094EB084FE"),
ProductType = ProductType.BillPayment,
ProductSubType = ProductSubType.BillPaymentPrePay
}

});
List<ContractProductModel> products = new();

products.AddRange(GetVoucherProducts());
products.AddRange(GetTopupProducts());
products.AddRange(GetBillPaymentProducts());

return Result.Success(products);
}

public async Task<Result<Decimal>> GetMerchantBalance(CancellationToken cancellationToken) {
Expand Down
Loading