Remove unsafe Json.NET type metadata from transaction request serialization#529
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/f85c3645-d44c-4c5c-9228-87be3055bc06 Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/f85c3645-d44c-4c5c-9228-87be3055bc06 Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix TypeNameHandling All unsafe usage in TransactionService
Remove unsafe Json.NET type metadata from transaction request serialization
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransactionServicewas serializing outbound request DTOs withTypeNameHandling.All, which causes Json.NET to emit$typemetadata and is unsafe in security-sensitive paths. This change removes that behavior from the mobile transaction request pipeline and adds coverage to prevent it from reappearing.Serialization change
JsonSerializerSettings { TypeNameHandling = TypeNameHandling.All }usage inTransactionService.SendTransactionRequest(...)with standard Json.NET serialization.Regression coverage
TransactionServicetest that captures the outbound logon request payload and verifies:$typemetadata is emittedResult
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
f.feedz.io/opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp(dns block)If you need me to access, download, or install something from one of these locations, you can either: