Skip to content

Improve MyAccount VM: error handling & code simplification #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 2 commits into from
Apr 15, 2026
Merged

Improve MyAccount VM: error handling & code simplification #536

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4989966
Improve MyAccount VM: error handling & code simplification
StuartFerguson Apr 15, 2026
ba626bb
Merge branch 'main' into task/#507_todo_complete
StuartFerguson Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions TransactionProcessor.Mobile.BusinessLogic/ViewModels/MyAccount/MyAccountPageViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,29 +68,25 @@ public String MerchantName {
#region Methods

public async Task Initialise(CancellationToken cancellationToken) {
this.MyAccountOptions = new List<ListViewItem> {
new ListViewItem {
Title = "Addresses"
},
new ListViewItem {
Title = "Contacts"
},
new ListViewItem {
Title = "Account Info"
},
new ListViewItem {
Title = "Logout"
}
};
this.MyAccountOptions = [
new() { Title = "Addresses" },
new() { Title = "Contacts" },
new() { Title = "Account Info" },
new() { Title = "Logout" }
];

GetMerchantDetailsRequest request = GetMerchantDetailsRequest.Create();

Result<MerchantDetailsModel> merchantDetailsResult = await this.Mediator.Send(request, cancellationToken);
// TODO: handle failure result
if (merchantDetailsResult.IsFailed) {
await this.DialogService.ShowWarningToast("Unable to load merchant details. Please try again later.", cancellationToken: cancellationToken);
return;
}

this.MerchantName = merchantDetailsResult.Data.MerchantName;

DateTime expirationTime = DateTime.Now.AddMinutes(60);
CancellationChangeToken expirationToken = new CancellationChangeToken(new CancellationTokenSource(TimeSpan.FromMinutes(60)).Token);
CancellationChangeToken expirationToken = new(new CancellationTokenSource(TimeSpan.FromMinutes(60)).Token);
MemoryCacheEntryOptions cacheEntryOptions = new MemoryCacheEntryOptions()
// Pin to cache.
.SetPriority(CacheItemPriority.NeverRemove)
Expand Down
Loading