Refactor cache expiration to use timeout seconds param#550
Closed
StuartFerguson wants to merge 2 commits intomainfrom
Closed
Refactor cache expiration to use timeout seconds param#550StuartFerguson wants to merge 2 commits intomainfrom
StuartFerguson wants to merge 2 commits intomainfrom
Conversation
Refactored ApplicationCache and related view models to accept an integer timeout (in seconds) for cache expiration instead of requiring MemoryCacheEntryOptions. The ApplicationCache class now constructs MemoryCacheEntryOptions internally based on the provided timeout. Updated all usages and tests to pass timeout values, simplifying cache management and reducing repetitive code. SetAccessToken remains flexible, still accepting MemoryCacheEntryOptions.
Up to standards ✅🟢 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 1 minor |
🟢 Metrics 0 complexity · -5 duplication
Metric Results Complexity 0 Duplication -5
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored ApplicationCache and related view models to accept an integer timeout (in seconds) for cache expiration instead of requiring MemoryCacheEntryOptions. The ApplicationCache class now constructs MemoryCacheEntryOptions internally based on the provided timeout. Updated all usages and tests to pass timeout values, simplifying cache management and reducing repetitive code. SetAccessToken remains flexible, still accepting MemoryCacheEntryOptions.
closes #538