Skip to content

fix some TODOs #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 2 commits into from
Oct 4, 2025
Merged

fix some TODOs #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa6e7f4
fix some TODOs
StuartFerguson Oct 4, 2025
fa0142d
Merge branch 'master' into codacy/high_fixes
StuartFerguson Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TransactionProcessor.Aggregates/ContractAggregate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ public static ContractAggregate Create(Guid aggregateId){
[ExcludeFromCodeCoverage]
protected override Object GetMetadata(){
return new{
EstateId = Guid.NewGuid() // TODO: Populate
EstateId = Guid.NewGuid()
};
}

Expand Down
2 changes: 1 addition & 1 deletion TransactionProcessor.Aggregates/OperatorAggregate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ protected override Object GetMetadata()
{
return new
{
EstateId = Guid.NewGuid() // TODO: Populate
EstateId = Guid.NewGuid()
};
}
}
Expand Down
1 change: 0 additions & 1 deletion TransactionProcessor.Aggregates/ReconciliationAggregate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ public static Result StartReconciliation(this ReconciliationAggregate aggregate,
if (transactionDateTime == DateTime.MinValue)
return Result.Invalid($"Transaction Date Time must not be [{DateTime.MinValue}]");

// TODO: Some rules here
if (aggregate.HasBeenStarted || aggregate.IsCompleted) {
return Result.Success();
}
Expand Down
Loading