Skip to content

Reduce reconciliation processing complexity in TransactionDomainService #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 3 commits into from
Mar 12, 2026
Merged

Reduce reconciliation processing complexity in TransactionDomainService #1595

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2feccdc
Initial plan
Copilot Mar 12, 2026
8b40ffd
Refactor reconciliation processing flow
Copilot Mar 12, 2026
aa359f4
Merge branch 'master' into copilot/fix-cyclomatic-complexity
StuartFerguson Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 36 additions & 32 deletions TransactionProcessor.BusinessLogic/Services/TransactionDomainService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,36 +152,13 @@ public async Task<Result<ProcessLogonTransactionResponse>> ProcessLogonTransacti
public async Task<Result<ProcessReconciliationTransactionResponse>> ProcessReconciliationTransaction(TransactionCommands.ProcessReconciliationCommand command,
CancellationToken cancellationToken) {
try{
Result<ReconciliationAggregate> reconciliationResult = await DomainServiceHelper.GetAggregateOrFailure(ct => this.AggregateService.GetLatest<ReconciliationAggregate>(command.TransactionId, ct), command.TransactionId, cancellationToken, false);
if (reconciliationResult.IsFailed)
return ResultHelpers.CreateFailure(reconciliationResult);

Result<ReconciliationAggregate> reconciliationResult = await DomainServiceHelper.GetAggregateOrFailure(ct => this.AggregateService.GetLatest<ReconciliationAggregate>(command.TransactionId, ct), command.TransactionId, cancellationToken, false);
if (reconciliationResult.IsFailed)
return ResultHelpers.CreateFailure(reconciliationResult);

ReconciliationAggregate reconciliationAggregate = reconciliationResult.Data;
Result<TransactionValidationResult> validationResult = await this.TransactionValidationService.ValidateReconciliationTransaction(command.EstateId, command.MerchantId, command.DeviceIdentifier, cancellationToken);

Result stateResult = reconciliationAggregate.StartReconciliation(command.TransactionDateTime, command.EstateId, command.MerchantId);
if (stateResult.IsFailed)
return ResultHelpers.CreateFailure(stateResult);

stateResult = reconciliationAggregate.RecordOverallTotals(command.TransactionCount, command.TransactionValue);
if (stateResult.IsFailed)
return ResultHelpers.CreateFailure(stateResult);

if (validationResult.IsSuccess && validationResult.Data.ResponseCode == TransactionResponseCode.Success) {
// Record the successful validation
stateResult = reconciliationAggregate.Authorise(validationResult.Data.ResponseCode, validationResult.Data.ResponseMessage);
if (stateResult.IsFailed)
return ResultHelpers.CreateFailure(stateResult);
}
else {
// Record the failure
stateResult = reconciliationAggregate.Decline(validationResult.Data.ResponseCode, validationResult.Data.ResponseMessage);
if (stateResult.IsFailed)
return ResultHelpers.CreateFailure(stateResult);
}

stateResult = reconciliationAggregate.CompleteReconciliation();
ReconciliationAggregate reconciliationAggregate = reconciliationResult.Data;
Result<TransactionValidationResult> validationResult = await this.TransactionValidationService.ValidateReconciliationTransaction(command.EstateId, command.MerchantId, command.DeviceIdentifier, cancellationToken);
Result stateResult = this.ProcessReconciliation(reconciliationAggregate, command, validationResult);
if (stateResult.IsFailed)
return ResultHelpers.CreateFailure(stateResult);

Expand Down Expand Up @@ -681,10 +658,37 @@ private Result StartTransaction(TransactionAggregate transactionAggregate,
return Result.Success();
}

private Result ProcessReconciliation(ReconciliationAggregate reconciliationAggregate,
TransactionCommands.ProcessReconciliationCommand command,
Result<TransactionValidationResult> validationResult) {
Result result = reconciliationAggregate.StartReconciliation(command.TransactionDateTime, command.EstateId, command.MerchantId);
if (result.IsFailed)
return result;

result = reconciliationAggregate.RecordOverallTotals(command.TransactionCount, command.TransactionValue);
if (result.IsFailed)
return result;

result = TransactionDomainService.ApplyReconciliationValidationResult(reconciliationAggregate, validationResult);
if (result.IsFailed)
return result;

return reconciliationAggregate.CompleteReconciliation();
}

private static Result ApplyReconciliationValidationResult(ReconciliationAggregate reconciliationAggregate,
Result<TransactionValidationResult> validationResult) {
if (validationResult.IsSuccess && validationResult.Data.ResponseCode == TransactionResponseCode.Success) {
return reconciliationAggregate.Authorise(validationResult.Data.ResponseCode, validationResult.Data.ResponseMessage);
}

return reconciliationAggregate.Decline(validationResult.Data.ResponseCode, validationResult.Data.ResponseMessage);
}

private async Task<(DateTime? Start, DateTime? End)> HandleOperatorProcessing(TransactionAggregate transactionAggregate,
TransactionCommands.ProcessSaleTransactionCommand command,
Result<TransactionValidationResult> validationResult,
CancellationToken cancellationToken) {
TransactionCommands.ProcessSaleTransactionCommand command,
Result<TransactionValidationResult> validationResult,
CancellationToken cancellationToken) {
DateTime? start = null, end = null;

if (validationResult.Data.ResponseCode != TransactionResponseCode.Success) {
Expand Down
Loading