Skip to content

Refactor GetContracts to reduce method length and isolate contract/product mapping #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 4 commits into from
Mar 17, 2026

Merge branch 'master' into copilot/fix-complexity-transactionprocesso…

d7d9874
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Refactor GetContracts to reduce method length and isolate contract/product mapping #1664

Merge branch 'master' into copilot/fix-complexity-transactionprocesso…
d7d9874
Select commit
Loading
Failed to load commit list.
GitHub Actions / Unit Test Results succeeded Mar 17, 2026 in 0s

1275 passed, 0 failed and 4 skipped

Tests passed successfully

Report Passed Failed Skipped Time
TransactionProcessor.Aggregates.Tests/TestResults/aggregates-test-results.trx 482✅ 1s
TransactionProcessor.BusinessLogic.Tests/TestResults/buslogic-test-results.trx 640✅ 3⚪ 61s
TransactionProcessor.DatabaseTests/TestResults/database-test-results.trx 26✅ 875s
TransactionProcessor.IntegrationTests/TestResults/integration-test-results.trx 9✅ 975s
TransactionProcessor.ProjectionEngine.Tests/TestResults/projection-test-results.trx 72✅ 898ms
TransactionProcessor.Tests/TestResults/tests-test-results.trx 46✅ 1⚪ 4s

✅ TransactionProcessor.Aggregates.Tests/TestResults/aggregates-test-results.trx

482 tests were completed in 1s with 482 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.Aggregates.Tests.ContractAggregateTests 93✅ 31ms
TransactionProcessor.Aggregates.Tests.EstateAggregateTests 18✅ 19ms
TransactionProcessor.Aggregates.Tests.FloatActivityAggregateTests 5✅ 19ms
TransactionProcessor.Aggregates.Tests.FloatAggregateTests 8✅ 25ms
TransactionProcessor.Aggregates.Tests.MerchantAggregateTests 74✅ 148ms
TransactionProcessor.Aggregates.Tests.MerchantDepositListAggregateTests 18✅ 55ms
TransactionProcessor.Aggregates.Tests.MerchantScheduleAggregateTests 7✅ 43ms
TransactionProcessor.Aggregates.Tests.MerchantStatementAggregateTests 17✅ 84ms
TransactionProcessor.Aggregates.Tests.MerchantStatementForDateAggregateTests 20✅ 26ms
TransactionProcessor.Aggregates.Tests.OperatorAggregateTests 13✅ 9ms
TransactionProcessor.Aggregates.Tests.ReconciliationAggregateTests 26✅ 52ms
TransactionProcessor.Aggregates.Tests.SettlementAggregateTests 26✅ 38ms
TransactionProcessor.Aggregates.Tests.TransactionAggregateTests 131✅ 131ms
TransactionProcessor.Aggregates.Tests.VoucherAggregateTests 26✅ 79ms

✅ TransactionProcessor.BusinessLogic.Tests/TestResults/buslogic-test-results.trx

643 tests were completed in 61s with 640 passed, 0 failed and 3 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.ContractDomainEventHandlerTests 5✅ 157ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.EstateDomainEventHandlerTests 4✅ 5ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.MerchantDomainEventHandlerTests 28✅ 1⚪ 54ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.MerchantScheduleDomainEventHandlerTests 2✅ 14ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.MerchantStatementDomainEventHandlerTests 12✅ 60s
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.OperatorDomainEventHandlerTests 4✅ 4ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.TransactionDomainEventHandlerTests 8✅ 151ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.VoucherDomainEventHandlerTests 2✅ 237ms
TransactionProcessor.BusinessLogic.Tests.Extensions.ExtensionsTests 2✅ 4ms
TransactionProcessor.BusinessLogic.Tests.Manager.FeeCalculationManagerTests 12✅ 11ms
TransactionProcessor.BusinessLogic.Tests.Manager.TransactionProcessorManagerTests 34✅ 74ms
TransactionProcessor.BusinessLogic.Tests.Manager.VoucherManagementManagerTests 4✅ 1s
TransactionProcessor.BusinessLogic.Tests.Mediator.MediatorTests 1✅ 6s
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.PataPawaPostPayProxyTests 19✅ 74ms
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.PataPawaPrePayProxyTests 20✅ 49ms
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.SafaricomPinlessProxyTests 16✅ 135ms
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.VoucherManagementProxyTests 10✅ 8ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.FloatRequestHandlerTests 2✅ 6ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.SettlementRequestHandlerTests 1✅ 7ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.TransactionRequestHandlerTests 4✅ 10ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.VoucherManagementRequestHandlerTests 2✅ 13ms
TransactionProcessor.BusinessLogic.Tests.Services.ContractDomainServiceTests 52✅ 142ms
TransactionProcessor.BusinessLogic.Tests.Services.DomainServiceHelperTests 4✅ 1ms
TransactionProcessor.BusinessLogic.Tests.Services.EstateDomainServiceTests 25✅ 436ms
TransactionProcessor.BusinessLogic.Tests.Services.FloatDomainServiceTests 20✅ 98ms
TransactionProcessor.BusinessLogic.Tests.Services.MerchantDomainServiceTests 152✅ 490ms
TransactionProcessor.BusinessLogic.Tests.Services.MerchantStatementDomainServiceTests 40✅ 230ms
TransactionProcessor.BusinessLogic.Tests.Services.OperatorDomainServiceTests 16✅ 29ms
TransactionProcessor.BusinessLogic.Tests.Services.SettlementDomainServiceTests 27✅ 15s
TransactionProcessor.BusinessLogic.Tests.Services.StatementBuilderTests 6✅ 243ms
TransactionProcessor.BusinessLogic.Tests.Services.TransactionDomainServiceTests 57✅ 256ms
TransactionProcessor.BusinessLogic.Tests.Services.TransactionReceiptBuilderTests 1✅ 2ms
TransactionProcessor.BusinessLogic.Tests.Services.TransactionValidationServiceTests 37✅ 2⚪ 226ms
TransactionProcessor.BusinessLogic.Tests.Services.VoucherDomainServiceTests 11✅ 495ms

✅ TransactionProcessor.DatabaseTests/TestResults/database-test-results.trx

26 tests were completed in 875s with 26 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.DatabaseTests.ContractEventTests 6✅ 577ms
TransactionProcessor.DatabaseTests.EstateEventTests 4✅ 125ms
TransactionProcessor.DatabaseTests.FileImportLogEventTests 4✅ 653ms
TransactionProcessor.DatabaseTests.MerchantEventTests 6✅ 216ms
TransactionProcessor.DatabaseTests.OperatorEventTests 2✅ 585ms
TransactionProcessor.DatabaseTests.ReconciliationEventTests 2✅ 96ms
TransactionProcessor.DatabaseTests.StatementEventTests 2✅ 76ms

✅ TransactionProcessor.IntegrationTests/TestResults/integration-test-results.trx

9 tests were completed in 975s with 9 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.IntegrationTests.Features.LogonTransactionFeature 1✅ 323s
TransactionProcessor.IntegrationTests.Features.MerchantFeature 2✅ 635s
TransactionProcessor.IntegrationTests.Features.OperatorFeature 1✅ 331s
TransactionProcessor.IntegrationTests.Features.ReconciliationFeature 1✅ 304s
TransactionProcessor.IntegrationTests.Features.RedeemVoucherFeature 1✅ 322s
TransactionProcessor.IntegrationTests.Features.SaleTransactionFeature 1✅ 325s
TransactionProcessor.IntegrationTests.Features.SettlementFeature 1✅ 323s
TransactionProcessor.IntegrationTests.Features.SettlementReportingFeature 1✅ 320s

✅ TransactionProcessor.ProjectionEngine.Tests/TestResults/projection-test-results.trx

72 tests were completed in 898ms with 72 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.ProjectionEngine.Tests.MerchantBalanceProjectionTests 27✅ 40ms
TransactionProcessor.ProjectionEngine.Tests.MerchantBalanceStateDispatcherTests 9✅ 146ms
TransactionProcessor.ProjectionEngine.Tests.MerchantBalanceStateExtensionsTests 13✅ 11ms
TransactionProcessor.ProjectionEngine.Tests.ProjectionHandlerTests 8✅ 122ms
TransactionProcessor.ProjectionEngine.Tests.VoucherProjectionTests 10✅ 5ms
TransactionProcessor.ProjectionEngine.Tests.VoucherStateDispatcherTests 1✅ 1ms
TransactionProcessor.ProjectionEngine.Tests.VoucherStateExtensionsTests 4✅ 5ms

✅ TransactionProcessor.Tests/TestResults/tests-test-results.trx

47 tests were completed in 4s with 46 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.Tests.Common.ExtensionsTests 2✅ 9ms
TransactionProcessor.Tests.ControllerTests.TransactionControllerTests 1⚪ 1ms
TransactionProcessor.Tests.Factories.ModelFactoryTests 43✅ 141ms
TransactionProcessor.Tests.General.BootstrapperTests 1✅ 3s
View more details on GitHub Actions