Skip to content

Reduce Startup.Configure complexity by extracting pipeline helpers #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 3 commits into from
Mar 18, 2026
Merged

Reduce Startup.Configure complexity by extracting pipeline helpers #1675

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18f2f89
Initial plan
Copilot Mar 18, 2026
3f406c0
Refactor Startup.Configure helpers
Copilot Mar 18, 2026
8cd88c5
Fix Startup trace output string
Copilot Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 44 additions & 37 deletions TransactionProcessor/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,7 @@ public void Configure(IApplicationBuilder app,
Logger.Initialise(logger);

Startup.Configuration.LogConfiguration(Logger.LogWarning);

foreach (KeyValuePair<Type, String> type in TypeMap.Map) {
Logger.LogInformation($"Type name {type.Value} mapped to {type.Key.Name}");
}
this.LogTypeMappings();
app.UseMiddleware<TenantMiddleware>();
app.AddRequestResponseLogging();
app.AddExceptionHandler();
Expand All @@ -125,44 +122,14 @@ public void Configure(IApplicationBuilder app,
app.UseAuthorization();
app.UseMetricServer(s => {
});
app.UseEndpoints(endpoints => {
endpoints.MapControllers();
endpoints.MapHealthChecks("health",
new HealthCheckOptions {
Predicate = _ => true,
ResponseWriter = Shared.HealthChecks.HealthCheckMiddleware.WriteResponse
});
endpoints.MapHealthChecks("healthui",
new HealthCheckOptions
{
Predicate = _ => true,
ResponseWriter = UIResponseWriter.WriteHealthCheckUIResponse
});
endpoints.MapEstateEndpoints();
endpoints.MapMerchantEndpoints();
endpoints.MapContractEndpoints();
endpoints.MapOperatorEndpoints();
endpoints.MapFloatEndpoints();
endpoints.MapVoucherEndpoints();
endpoints.MapTransactionEndpoints();
endpoints.MapSettlementEndpoints();
});
this.ConfigureEndpoints(app);

app.UseSwagger();

app.UseSwaggerUI();

app.PreWarm();

var loadedTokensAssemblies = AppDomain.CurrentDomain
.GetAssemblies()
.Where(a => a.GetName().Name == "Microsoft.IdentityModel.Tokens")
.ToList();

foreach (var asm in loadedTokensAssemblies)
{
Console.WriteLine($"[Trace] Tokens Assembly: {asm.Location} — Version: {asm.GetName().Version}");
}
this.TraceLoadedTokenAssemblies();
}

public void ConfigureContainer(ServiceRegistry services) {
Expand All @@ -186,7 +153,47 @@ public void ConfigureContainer(ServiceRegistry services) {

Startup.ServiceProvider = services.BuildServiceProvider();
}

private void ConfigureEndpoints(IApplicationBuilder app) {
app.UseEndpoints(endpoints => {
endpoints.MapControllers();
endpoints.MapHealthChecks("health",
new HealthCheckOptions {
Predicate = _ => true,
ResponseWriter = Shared.HealthChecks.HealthCheckMiddleware.WriteResponse
});
endpoints.MapHealthChecks("healthui",
new HealthCheckOptions {
Predicate = _ => true,
ResponseWriter = UIResponseWriter.WriteHealthCheckUIResponse
});
endpoints.MapEstateEndpoints();
endpoints.MapMerchantEndpoints();
endpoints.MapContractEndpoints();
endpoints.MapOperatorEndpoints();
endpoints.MapFloatEndpoints();
endpoints.MapVoucherEndpoints();
endpoints.MapTransactionEndpoints();
endpoints.MapSettlementEndpoints();
});
}

private void LogTypeMappings() {
foreach (KeyValuePair<Type, String> type in TypeMap.Map) {
Logger.LogInformation($"Type name {type.Value} mapped to {type.Key.Name}");
}
}

private void TraceLoadedTokenAssemblies() {
List<Assembly> loadedTokensAssemblies = AppDomain.CurrentDomain.GetAssemblies()
.Where(a => a.GetName().Name == "Microsoft.IdentityModel.Tokens")
.ToList();

foreach (Assembly asm in loadedTokensAssemblies) {
Console.WriteLine($"[Trace] Tokens Assembly: {asm.Location} - Version: {asm.GetName().Version}");
}
}
}

#endregion
}
}
Loading