Skip to content

Reduce EstateDomainService.CreateEstateUser complexity by extracting user creation helpers #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 2 commits into from
Mar 18, 2026

Refactor estate user creation flow

54e0e23
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Reduce EstateDomainService.CreateEstateUser complexity by extracting user creation helpers #1691

Refactor estate user creation flow
54e0e23
Select commit
Loading
Failed to load commit list.
GitHub Actions / Unit Test Results succeeded Mar 18, 2026 in 0s

1280 passed, 0 failed and 4 skipped

Tests passed successfully

Report Passed Failed Skipped Time
TransactionProcessor.Aggregates.Tests/TestResults/aggregates-test-results.trx 483✅ 1s
TransactionProcessor.BusinessLogic.Tests/TestResults/buslogic-test-results.trx 644✅ 3⚪ 63s
TransactionProcessor.DatabaseTests/TestResults/database-test-results.trx 26✅ 731s
TransactionProcessor.IntegrationTests/TestResults/integration-test-results.trx 9✅ 953s
TransactionProcessor.ProjectionEngine.Tests/TestResults/projection-test-results.trx 72✅ 810ms
TransactionProcessor.Tests/TestResults/tests-test-results.trx 46✅ 1⚪ 3s

✅ TransactionProcessor.Aggregates.Tests/TestResults/aggregates-test-results.trx

483 tests were completed in 1s with 483 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.Aggregates.Tests.ContractAggregateTests 93✅ 46ms
TransactionProcessor.Aggregates.Tests.EstateAggregateTests 18✅ 14ms
TransactionProcessor.Aggregates.Tests.FloatActivityAggregateTests 5✅ 69ms
TransactionProcessor.Aggregates.Tests.FloatAggregateTests 8✅ 16ms
TransactionProcessor.Aggregates.Tests.MerchantAggregateTests 74✅ 181ms
TransactionProcessor.Aggregates.Tests.MerchantDepositListAggregateTests 18✅ 54ms
TransactionProcessor.Aggregates.Tests.MerchantScheduleAggregateTests 7✅ 23ms
TransactionProcessor.Aggregates.Tests.MerchantStatementAggregateTests 17✅ 25ms
TransactionProcessor.Aggregates.Tests.MerchantStatementForDateAggregateTests 21✅ 72ms
TransactionProcessor.Aggregates.Tests.OperatorAggregateTests 13✅ 20ms
TransactionProcessor.Aggregates.Tests.ReconciliationAggregateTests 26✅ 32ms
TransactionProcessor.Aggregates.Tests.SettlementAggregateTests 26✅ 44ms
TransactionProcessor.Aggregates.Tests.TransactionAggregateTests 131✅ 153ms
TransactionProcessor.Aggregates.Tests.VoucherAggregateTests 26✅ 29ms

✅ TransactionProcessor.BusinessLogic.Tests/TestResults/buslogic-test-results.trx

647 tests were completed in 63s with 644 passed, 0 failed and 3 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.ContractDomainEventHandlerTests 5✅ 95ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.EstateDomainEventHandlerTests 4✅ 7ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.MerchantDomainEventHandlerTests 28✅ 1⚪ 37ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.MerchantScheduleDomainEventHandlerTests 2✅ 6ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.MerchantStatementDomainEventHandlerTests 12✅ 60s
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.OperatorDomainEventHandlerTests 4✅ 3ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.ReadModelDomainEventHandlerTests 3✅ 14ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.TransactionDomainEventHandlerTests 8✅ 87ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.VoucherDomainEventHandlerTests 2✅ 127ms
TransactionProcessor.BusinessLogic.Tests.Extensions.ExtensionsTests 2✅ 0ms
TransactionProcessor.BusinessLogic.Tests.Manager.FeeCalculationManagerTests 12✅ 17ms
TransactionProcessor.BusinessLogic.Tests.Manager.TransactionProcessorManagerTests 34✅ 86ms
TransactionProcessor.BusinessLogic.Tests.Manager.VoucherManagementManagerTests 4✅ 50ms
TransactionProcessor.BusinessLogic.Tests.Mediator.MediatorTests 1✅ 4s
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.PataPawaPostPayProxyTests 19✅ 34ms
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.PataPawaPrePayProxyTests 20✅ 48ms
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.SafaricomPinlessProxyTests 16✅ 317ms
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.VoucherManagementProxyTests 10✅ 125ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.FloatRequestHandlerTests 2✅ 9ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.SettlementRequestHandlerTests 1✅ 6ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.TransactionRequestHandlerTests 4✅ 16ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.VoucherManagementRequestHandlerTests 2✅ 8ms
TransactionProcessor.BusinessLogic.Tests.Services.ContractDomainServiceTests 52✅ 111ms
TransactionProcessor.BusinessLogic.Tests.Services.DomainServiceHelperTests 4✅ 1ms
TransactionProcessor.BusinessLogic.Tests.Services.EstateDomainServiceTests 26✅ 73ms
TransactionProcessor.BusinessLogic.Tests.Services.FloatDomainServiceTests 20✅ 210ms
TransactionProcessor.BusinessLogic.Tests.Services.MerchantDomainServiceTests 152✅ 422ms
TransactionProcessor.BusinessLogic.Tests.Services.MerchantStatementDomainServiceTests 40✅ 143ms
TransactionProcessor.BusinessLogic.Tests.Services.OperatorDomainServiceTests 16✅ 27ms
TransactionProcessor.BusinessLogic.Tests.Services.SettlementDomainServiceTests 27✅ 15s
TransactionProcessor.BusinessLogic.Tests.Services.StatementBuilderTests 6✅ 720ms
TransactionProcessor.BusinessLogic.Tests.Services.TransactionDomainServiceTests 57✅ 192ms
TransactionProcessor.BusinessLogic.Tests.Services.TransactionReceiptBuilderTests 1✅ 70ms
TransactionProcessor.BusinessLogic.Tests.Services.TransactionValidationServiceTests 37✅ 2⚪ 135ms
TransactionProcessor.BusinessLogic.Tests.Services.VoucherDomainServiceTests 11✅ 2s

✅ TransactionProcessor.DatabaseTests/TestResults/database-test-results.trx

26 tests were completed in 731s with 26 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.DatabaseTests.ContractEventTests 6✅ 188ms
TransactionProcessor.DatabaseTests.EstateEventTests 4✅ 90ms
TransactionProcessor.DatabaseTests.FileImportLogEventTests 4✅ 111ms
TransactionProcessor.DatabaseTests.MerchantEventTests 6✅ 217ms
TransactionProcessor.DatabaseTests.OperatorEventTests 2✅ 240ms
TransactionProcessor.DatabaseTests.ReconciliationEventTests 2✅ 375ms
TransactionProcessor.DatabaseTests.StatementEventTests 2✅ 356ms

✅ TransactionProcessor.IntegrationTests/TestResults/integration-test-results.trx

9 tests were completed in 953s with 9 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.IntegrationTests.Features.LogonTransactionFeature 1✅ 325s
TransactionProcessor.IntegrationTests.Features.MerchantFeature 2✅ 622s
TransactionProcessor.IntegrationTests.Features.OperatorFeature 1✅ 330s
TransactionProcessor.IntegrationTests.Features.ReconciliationFeature 1✅ 313s
TransactionProcessor.IntegrationTests.Features.RedeemVoucherFeature 1✅ 298s
TransactionProcessor.IntegrationTests.Features.SaleTransactionFeature 1✅ 320s
TransactionProcessor.IntegrationTests.Features.SettlementFeature 1✅ 299s
TransactionProcessor.IntegrationTests.Features.SettlementReportingFeature 1✅ 314s

✅ TransactionProcessor.ProjectionEngine.Tests/TestResults/projection-test-results.trx

72 tests were completed in 810ms with 72 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.ProjectionEngine.Tests.MerchantBalanceProjectionTests 27✅ 23ms
TransactionProcessor.ProjectionEngine.Tests.MerchantBalanceStateDispatcherTests 9✅ 73ms
TransactionProcessor.ProjectionEngine.Tests.MerchantBalanceStateExtensionsTests 13✅ 14ms
TransactionProcessor.ProjectionEngine.Tests.ProjectionHandlerTests 8✅ 140ms
TransactionProcessor.ProjectionEngine.Tests.VoucherProjectionTests 10✅ 42ms
TransactionProcessor.ProjectionEngine.Tests.VoucherStateDispatcherTests 1✅ 1ms
TransactionProcessor.ProjectionEngine.Tests.VoucherStateExtensionsTests 4✅ 2ms

✅ TransactionProcessor.Tests/TestResults/tests-test-results.trx

47 tests were completed in 3s with 46 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.Tests.Common.ExtensionsTests 2✅ 8ms
TransactionProcessor.Tests.ControllerTests.TransactionControllerTests 1⚪ 1ms
TransactionProcessor.Tests.Factories.ModelFactoryTests 43✅ 135ms
TransactionProcessor.Tests.General.BootstrapperTests 1✅ 3s
View more details on GitHub Actions