Reduce cyclomatic complexity of ContractDomainService.CreateContract from 11 to 8

[Copilot]

CreateContract exceeded Codacy's cyclomatic complexity limit of 8 (reported as 11) due to the operator validation and duplicate contract-name check being inlined alongside the aggregate fetch/save flow.

Changes

• Extracted ValidateContractCreationPreConditions — new private async helper encapsulates the operator-on-estate check and the EventStore transient-query duplicate-name check, replacing 4 decision points in CreateContract with a single if (preConditionResult.IsFailed) guard.
• Fixed null-safety in JSON parsing — replaced the fragile jsonResult.Property("contractId").Values<String>().Single() chain (throws on missing property) with the safe jsonResult["contractId"]?.Value<String>(), combining the Guid.TryParse boolean return with the empty-GUID check into one condition.

// Before: all inlined in CreateContract (complexity 11)
if (estate.Operators.Any(o => o.OperatorId == command.RequestDTO.OperatorId) == false) { ... }
Result<String> result = await this.Context.RunTransientQuery(projection, cancellationToken);
if (result.IsFailed) ...
if (String.IsNullOrEmpty(resultString) == false) {
    ...
    if (contractIdResult != Guid.Empty) { ... }
}

// After: delegated to helper (CreateContract complexity 8)
Result preConditionResult = await this.ValidateContractCreationPreConditions(command, estate, cancellationToken);
if (preConditionResult.IsFailed)
    return preConditionResult;

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet test TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter ContractDomainService_ --no-restore -nologo (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter ContractDomainService_ --no-restore -nologo -v normal (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter ContractDomainService_ --no-restore (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 4 complexity · 0 duplication

Metric	Results
Complexity	4
Duplication	0

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}