Skip to content

Remove obsolete TODOs and commented code; add AddFile method #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 2 commits into from
Apr 8, 2026

Merge branch 'master' into task/#1677_remove_some_todos

726c2cb
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Remove obsolete TODOs and commented code; add AddFile method #1725

Merge branch 'master' into task/#1677_remove_some_todos
726c2cb
Select commit
Loading
Failed to load commit list.
GitHub Actions / Unit Test Results succeeded Apr 8, 2026 in 0s

1285 passed, 0 failed and 4 skipped

Tests passed successfully

Report Passed Failed Skipped Time
TransactionProcessor.Aggregates.Tests/TestResults/aggregates-test-results.trx 484✅ 1s
TransactionProcessor.BusinessLogic.Tests/TestResults/buslogic-test-results.trx 644✅ 3⚪ 63s
TransactionProcessor.DatabaseTests/TestResults/database-test-results.trx 26✅ 872s
TransactionProcessor.IntegrationTests/TestResults/integration-test-results.trx 9✅ 995s
TransactionProcessor.ProjectionEngine.Tests/TestResults/projection-test-results.trx 72✅ 791ms
TransactionProcessor.Tests/TestResults/tests-test-results.trx 50✅ 1⚪ 1s

✅ TransactionProcessor.Aggregates.Tests/TestResults/aggregates-test-results.trx

484 tests were completed in 1s with 484 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.Aggregates.Tests.ContractAggregateTests 93✅ 98ms
TransactionProcessor.Aggregates.Tests.EstateAggregateTests 18✅ 33ms
TransactionProcessor.Aggregates.Tests.FloatActivityAggregateTests 5✅ 5ms
TransactionProcessor.Aggregates.Tests.FloatAggregateTests 8✅ 63ms
TransactionProcessor.Aggregates.Tests.MerchantAggregateTests 74✅ 132ms
TransactionProcessor.Aggregates.Tests.MerchantDepositListAggregateTests 18✅ 35ms
TransactionProcessor.Aggregates.Tests.MerchantScheduleAggregateTests 7✅ 33ms
TransactionProcessor.Aggregates.Tests.MerchantStatementAggregateTests 17✅ 27ms
TransactionProcessor.Aggregates.Tests.MerchantStatementForDateAggregateTests 21✅ 21ms
TransactionProcessor.Aggregates.Tests.OperatorAggregateTests 13✅ 12ms
TransactionProcessor.Aggregates.Tests.ReconciliationAggregateTests 26✅ 25ms
TransactionProcessor.Aggregates.Tests.SettlementAggregateTests 26✅ 50ms
TransactionProcessor.Aggregates.Tests.TransactionAggregateTests 132✅ 151ms
TransactionProcessor.Aggregates.Tests.VoucherAggregateTests 26✅ 26ms

✅ TransactionProcessor.BusinessLogic.Tests/TestResults/buslogic-test-results.trx

647 tests were completed in 63s with 644 passed, 0 failed and 3 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.ContractDomainEventHandlerTests 5✅ 5ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.EstateDomainEventHandlerTests 4✅ 7ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.MerchantDomainEventHandlerTests 28✅ 1⚪ 37ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.MerchantScheduleDomainEventHandlerTests 2✅ 233ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.MerchantStatementDomainEventHandlerTests 12✅ 60s
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.OperatorDomainEventHandlerTests 4✅ 10ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.ReadModelDomainEventHandlerTests 3✅ 10ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.TransactionDomainEventHandlerTests 8✅ 164ms
TransactionProcessor.BusinessLogic.Tests.DomainEventHandlers.VoucherDomainEventHandlerTests 2✅ 820ms
TransactionProcessor.BusinessLogic.Tests.Extensions.ExtensionsTests 2✅ 1ms
TransactionProcessor.BusinessLogic.Tests.Manager.FeeCalculationManagerTests 12✅ 14ms
TransactionProcessor.BusinessLogic.Tests.Manager.TransactionProcessorManagerTests 34✅ 258ms
TransactionProcessor.BusinessLogic.Tests.Manager.VoucherManagementManagerTests 4✅ 470ms
TransactionProcessor.BusinessLogic.Tests.Mediator.MediatorTests 1✅ 1s
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.PataPawaPostPayProxyTests 19✅ 365ms
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.PataPawaPrePayProxyTests 20✅ 897ms
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.SafaricomPinlessProxyTests 16✅ 66ms
TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces.VoucherManagementProxyTests 10✅ 6ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.FloatRequestHandlerTests 2✅ 9ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.SettlementRequestHandlerTests 1✅ 10ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.TransactionRequestHandlerTests 4✅ 15ms
TransactionProcessor.BusinessLogic.Tests.RequestHandler.VoucherManagementRequestHandlerTests 2✅ 7ms
TransactionProcessor.BusinessLogic.Tests.Services.ContractDomainServiceTests 52✅ 132ms
TransactionProcessor.BusinessLogic.Tests.Services.DomainServiceHelperTests 4✅ 5ms
TransactionProcessor.BusinessLogic.Tests.Services.EstateDomainServiceTests 26✅ 74ms
TransactionProcessor.BusinessLogic.Tests.Services.FloatDomainServiceTests 20✅ 51ms
TransactionProcessor.BusinessLogic.Tests.Services.MerchantDomainServiceTests 152✅ 515ms
TransactionProcessor.BusinessLogic.Tests.Services.MerchantStatementDomainServiceTests 40✅ 135ms
TransactionProcessor.BusinessLogic.Tests.Services.OperatorDomainServiceTests 16✅ 57ms
TransactionProcessor.BusinessLogic.Tests.Services.SettlementDomainServiceTests 27✅ 15s
TransactionProcessor.BusinessLogic.Tests.Services.StatementBuilderTests 6✅ 57ms
TransactionProcessor.BusinessLogic.Tests.Services.TransactionDomainServiceTests 57✅ 344ms
TransactionProcessor.BusinessLogic.Tests.Services.TransactionReceiptBuilderTests 1✅ 54ms
TransactionProcessor.BusinessLogic.Tests.Services.TransactionValidationServiceTests 37✅ 2⚪ 280ms
TransactionProcessor.BusinessLogic.Tests.Services.VoucherDomainServiceTests 11✅ 1s

✅ TransactionProcessor.DatabaseTests/TestResults/database-test-results.trx

26 tests were completed in 872s with 26 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.DatabaseTests.ContractEventTests 6✅ 190ms
TransactionProcessor.DatabaseTests.EstateEventTests 4✅ 110ms
TransactionProcessor.DatabaseTests.FileImportLogEventTests 4✅ 95ms
TransactionProcessor.DatabaseTests.MerchantEventTests 6✅ 159ms
TransactionProcessor.DatabaseTests.OperatorEventTests 2✅ 538ms
TransactionProcessor.DatabaseTests.ReconciliationEventTests 2✅ 386ms
TransactionProcessor.DatabaseTests.StatementEventTests 2✅ 84ms

✅ TransactionProcessor.IntegrationTests/TestResults/integration-test-results.trx

9 tests were completed in 995s with 9 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.IntegrationTests.Features.LogonTransactionFeature 1✅ 322s
TransactionProcessor.IntegrationTests.Features.MerchantFeature 2✅ 658s
TransactionProcessor.IntegrationTests.Features.OperatorFeature 1✅ 320s
TransactionProcessor.IntegrationTests.Features.ReconciliationFeature 1✅ 317s
TransactionProcessor.IntegrationTests.Features.RedeemVoucherFeature 1✅ 294s
TransactionProcessor.IntegrationTests.Features.SaleTransactionFeature 1✅ 332s
TransactionProcessor.IntegrationTests.Features.SettlementFeature 1✅ 298s
TransactionProcessor.IntegrationTests.Features.SettlementReportingFeature 1✅ 336s

✅ TransactionProcessor.ProjectionEngine.Tests/TestResults/projection-test-results.trx

72 tests were completed in 791ms with 72 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.ProjectionEngine.Tests.MerchantBalanceProjectionTests 27✅ 16ms
TransactionProcessor.ProjectionEngine.Tests.MerchantBalanceStateDispatcherTests 9✅ 100ms
TransactionProcessor.ProjectionEngine.Tests.MerchantBalanceStateExtensionsTests 13✅ 17ms
TransactionProcessor.ProjectionEngine.Tests.ProjectionHandlerTests 8✅ 121ms
TransactionProcessor.ProjectionEngine.Tests.VoucherProjectionTests 10✅ 7ms
TransactionProcessor.ProjectionEngine.Tests.VoucherStateDispatcherTests 1✅ 1ms
TransactionProcessor.ProjectionEngine.Tests.VoucherStateExtensionsTests 4✅ 16ms

✅ TransactionProcessor.Tests/TestResults/tests-test-results.trx

51 tests were completed in 1s with 50 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
TransactionProcessor.Tests.Common.ExtensionsTests 2✅ 1ms
TransactionProcessor.Tests.ControllerTests.TransactionControllerTests 1⚪ 1ms
TransactionProcessor.Tests.Factories.ModelFactoryTests 43✅ 120ms
TransactionProcessor.Tests.General.BootstrapperTests 1✅ 472ms
TransactionProcessor.Tests.HandlerTests.TransactionHandlersTests 4✅ 173ms
View more details on GitHub Actions