Refactor PolicyFactory and update SettlementDomainService#790
Merged
StuartFerguson merged 1 commit intomasterfrom Apr 29, 2025
Merged
Refactor PolicyFactory and update SettlementDomainService#790StuartFerguson merged 1 commit intomasterfrom
StuartFerguson merged 1 commit intomasterfrom
Conversation
Refactored the PolicyFactory class for improved structure and functionality, enhancing retry policy creation and logging. Updated the ExecuteWithPolicyAsync methods for better readability and maintainability, introducing new methods for retry logic and logging. In SettlementDomainService, modified the ProcessSettlement method to utilize the new policy execution methods, improving error handling and resilience. Enhanced method structure and logging practices for better clarity and flow tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the PolicyFactory class for improved structure and functionality, enhancing retry policy creation and logging. Updated the ExecuteWithPolicyAsync methods for better readability and maintainability, introducing new methods for retry logic and logging.
In SettlementDomainService, modified the ProcessSettlement method to utilize the new policy execution methods, improving error handling and resilience. Enhanced method structure and logging practices for better clarity and flow tracking.