Skip to content

Caching improvements added #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 5 commits into from
Aug 18, 2025

:|

aecf8d4
Select commit
Loading
Failed to load commit list.
Merged

Caching improvements added #859

:|
aecf8d4
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Aug 18, 2025 in 0s

3 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 4
- Added 3
           

Complexity increasing per file
==============================
- TransactionProcessor.BusinessLogic/Services/TransactionValidationService.cs  39
- TransactionProcessor.BusinessLogic.Tests/Services/FloatDomainServiceTests.cs  10
- TransactionProcessor.BusinessLogic.Tests/Services/TransactionValidationServiceTests.cs  38
- TransactionProcessor/Bootstrapper/RepositoryRegistry.cs  1
- TransactionProcessor.BusinessLogic/Services/OperatorDomainService.cs  6
- TransactionProcessor.BusinessLogic.Tests/Services/ContractDomainServiceTests.cs  16
- TransactionProcessor.BusinessLogic.Tests/Services/OperatorDomainServiceTests.cs  5
- TransactionProcessor.BusinessLogic/Services/MerchantDomainService.cs  102
         

Clones added
============
- TransactionProcessor.BusinessLogic.Tests/Services/VoucherDomainServiceTests.cs  1
- TransactionProcessor.BusinessLogic.Tests/Services/FloatDomainServiceTests.cs  1
- TransactionProcessor.BusinessLogic/Services/EstateDomainService.cs  1
- TransactionProcessor.BusinessLogic/Services/MerchantDomainService.cs  64
         

Clones removed
==============
+ TransactionProcessor.BusinessLogic/Services/OperatorDomainService.cs  -1
+ TransactionProcessor.BusinessLogic.Tests/Services/MerchantDomainServiceTests.cs  -16

See the complete overview on Codacy

Annotations

Check notice on line 80 in TransactionProcessor.BusinessLogic/Services/MerchantDomainService.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

TransactionProcessor.BusinessLogic/Services/MerchantDomainService.cs#L80 

Replace this 'switch' expression with a ternary conditional operator to increase readability.

Check notice on line 623 in TransactionProcessor.BusinessLogic/Services/MerchantDomainService.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

TransactionProcessor.BusinessLogic/Services/MerchantDomainService.cs#L623 

Remove this empty statement.

Check warning on line 79 in TransactionProcessor/Bootstrapper/RepositoryRegistry.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

TransactionProcessor/Bootstrapper/RepositoryRegistry.cs#L79 

Remove this assignment of 'CachedAggregatesAdded' or initialize it statically.
View more details on Codacy Production