Performance tweaks on domain service #860
3 new issues (0 max.) of at least severity.
Here is an overview of what got changed by this pull request:
Issues
======
+ Solved 1
- Added 3
Complexity increasing per file
==============================
- TransactionProcessor.BusinessLogic/Services/FloatDomainService.cs 1
- TransactionProcessor.BusinessLogic/Services/OperatorDomainService.cs 3
Complexity decreasing per file
==============================
+ TransactionProcessor.BusinessLogic/Services/MerchantDomainService.cs -1
Clones added
============
- TransactionProcessor.BusinessLogic/Services/OperatorDomainService.cs 8
- TransactionProcessor.BusinessLogic/Services/MerchantDomainService.cs 12
See the complete overview on Codacy
Annotations
Check warning on line 192 in TransactionProcessor.BusinessLogic/Services/FloatDomainService.cs
codacy-production / Codacy Static Code Analysis
TransactionProcessor.BusinessLogic/Services/FloatDomainService.cs#L192
Use the overloading mechanism instead of the optional parameters.
Check notice on line 195 in TransactionProcessor.BusinessLogic/Services/FloatDomainService.cs
codacy-production / Codacy Static Code Analysis
TransactionProcessor.BusinessLogic/Services/FloatDomainService.cs#L195
Replace this 'switch' expression with a ternary conditional operator to increase readability.
Check notice on line 78 in TransactionProcessor.BusinessLogic/Services/MerchantDomainService.cs
codacy-production / Codacy Static Code Analysis
TransactionProcessor.BusinessLogic/Services/MerchantDomainService.cs#L78
Remove this commented out code.