Skip to content

Refactor voucher methods to use Result<T> for responses #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Apr 8, 2026
Merged

Refactor voucher methods to use Result<T> for responses #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions TransactionProcessorACL.BusinessLogic.Tests/MediatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,20 +128,20 @@ public async Task<Result<ProcessReconciliationResponse>> ProcessReconciliation(G
Decimal transactionValue,
CancellationToken cancellationToken) => Result.Success(new ProcessReconciliationResponse());

public async Task<GetVoucherResponse> GetVoucher(Guid estateId,
Guid contractId,
String voucherCode,
CancellationToken cancellationToken)
public async Task<Result<GetVoucherResponse>> GetVoucher(Guid estateId,
Guid contractId,
String voucherCode,
CancellationToken cancellationToken)
{
return new GetVoucherResponse();
return Result.Success(new GetVoucherResponse());
}

public async Task<RedeemVoucherResponse> RedeemVoucher(Guid estateId,
Guid contractId,
String voucherCode,
public async Task<Result<RedeemVoucherResponse>> RedeemVoucher(Guid estateId,
Guid contractId,
String voucherCode,
CancellationToken cancellationToken)
{
return new RedeemVoucherResponse();
return Result.Success(new RedeemVoucherResponse());
}

public async Task<Result<List<ContractResponse>>> GetMerchantContracts(Guid estateId,
Expand Down
59 changes: 26 additions & 33 deletions ...sactionProcessorACL.BusinessLogic.Tests/TransactionProcessorACLApplicationServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,26 +416,26 @@ public async Task VoucherManagementACLApplicationService_GetVoucher_VoucherRetri
.ReturnsAsync(TestData.GetVoucherResponse);
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.TokenResponse));

GetVoucherResponse voucherResponse = await applicationService.GetVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);

voucherResponse.ShouldNotBeNull();
voucherResponse.VoucherCode.ShouldBe(TestData.GetVoucherResponse.VoucherCode);
voucherResponse.ContractId.ShouldBe(TestData.ContractId);
voucherResponse.EstateId.ShouldBe(TestData.EstateId);
voucherResponse.ExpiryDate.ShouldBe(TestData.GetVoucherResponse.ExpiryDate);
voucherResponse.Value.ShouldBe(TestData.GetVoucherResponse.Value);
voucherResponse.VoucherId.ShouldBe(TestData.GetVoucherResponse.VoucherId);
Result<GetVoucherResponse> voucherResponse = await applicationService.GetVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);

voucherResponse.IsSuccess.ShouldBeTrue();
voucherResponse.Data.ShouldNotBeNull();
voucherResponse.Data.VoucherCode.ShouldBe(TestData.GetVoucherResponse.VoucherCode);
voucherResponse.Data.ContractId.ShouldBe(TestData.ContractId);
voucherResponse.Data.EstateId.ShouldBe(TestData.EstateId);
voucherResponse.Data.ExpiryDate.ShouldBe(TestData.GetVoucherResponse.ExpiryDate);
voucherResponse.Data.Value.ShouldBe(TestData.GetVoucherResponse.Value);
voucherResponse.Data.VoucherId.ShouldBe(TestData.GetVoucherResponse.VoucherId);
}

[Fact]
public async Task VoucherManagementACLApplicationService_GetVoucher_GetTokenFailed_ResultIsFailed()
{
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure());

GetVoucherResponse voucherResponse = await applicationService.GetVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);
Result<GetVoucherResponse> voucherResponse = await applicationService.GetVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);

voucherResponse.ShouldNotBeNull();
voucherResponse.ResponseCode.ShouldBe("0004");
voucherResponse.IsFailed.ShouldBeTrue();
}

[Fact]
Expand All @@ -445,10 +445,9 @@ public async Task VoucherManagementACLApplicationService_GetVoucher_GetVoucherFa
.ReturnsAsync(Result.Failure());
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.TokenResponse));

GetVoucherResponse voucherResponse = await applicationService.GetVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);
Result<GetVoucherResponse> voucherResponse = await applicationService.GetVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);

voucherResponse.ShouldNotBeNull();
voucherResponse.ResponseCode.ShouldBe("0005");
voucherResponse.IsFailed.ShouldBeTrue();
}

[Fact]
Expand All @@ -458,11 +457,9 @@ public async Task VoucherManagementACLApplicationService_GetVoucher_ExceptionErr
.ThrowsAsync(new Exception("Error"));
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.TokenResponse));

GetVoucherResponse voucherResponse = await applicationService.GetVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);
Result<GetVoucherResponse> voucherResponse = await applicationService.GetVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);

voucherResponse.ShouldNotBeNull();
voucherResponse.ResponseMessage.ShouldBe(TestData.VoucherExceptionResponseMessage);
voucherResponse.ResponseCode.ShouldBe(TestData.ExceptionErrorResponseCode);
voucherResponse.IsFailed.ShouldBeTrue();
}

[Fact]
Expand All @@ -472,11 +469,11 @@ public async Task VoucherManagementACLApplicationService_RedeemVoucher_VoucherRe
.ReturnsAsync(Result.Success);
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.TokenResponse));

RedeemVoucherResponse voucherResponse = await applicationService.RedeemVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);
Result<RedeemVoucherResponse> voucherResponse = await applicationService.RedeemVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);

voucherResponse.ShouldNotBeNull();
voucherResponse.ContractId.ShouldBe(TestData.ContractId);
voucherResponse.EstateId.ShouldBe(TestData.EstateId);
voucherResponse.IsSuccess.ShouldBeTrue();
voucherResponse.Data.ContractId.ShouldBe(TestData.ContractId);
voucherResponse.Data.EstateId.ShouldBe(TestData.EstateId);
}

[Fact]
Expand All @@ -486,10 +483,9 @@ public async Task VoucherManagementACLApplicationService_RedeemVoucher_GetTokenF
.ReturnsAsync(Result.Failure);
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure());

RedeemVoucherResponse voucherResponse = await applicationService.RedeemVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);
Result<RedeemVoucherResponse> voucherResponse = await applicationService.RedeemVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);

voucherResponse.ShouldNotBeNull();
voucherResponse.ResponseCode.ShouldBe("0004");
voucherResponse.IsFailed.ShouldBeTrue();
}

[Fact]
Expand All @@ -499,10 +495,9 @@ public async Task VoucherManagementACLApplicationService_RedeemVoucher_RedeemVou
.ReturnsAsync(Result.Failure());
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.TokenResponse));

RedeemVoucherResponse voucherResponse = await applicationService.RedeemVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);
Result<RedeemVoucherResponse> voucherResponse = await applicationService.RedeemVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);

voucherResponse.ShouldNotBeNull();
voucherResponse.ResponseCode.ShouldBe("0005");
voucherResponse.IsFailed.ShouldBeTrue();
}

[Fact]
Expand All @@ -513,11 +508,9 @@ public async Task VoucherManagementACLApplicationService_RedeemVoucher_Exception

securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.TokenResponse));

RedeemVoucherResponse voucherResponse = await applicationService.RedeemVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);
Result<RedeemVoucherResponse> voucherResponse = await applicationService.RedeemVoucher(TestData.EstateId, TestData.ContractId, TestData.VoucherCode, CancellationToken.None);

voucherResponse.ShouldNotBeNull();
voucherResponse.ResponseMessage.ShouldBe(TestData.RedeemVoucherExceptionResponseMessage);
voucherResponse.ResponseCode.ShouldBe(TestData.ExceptionErrorResponseCode);
voucherResponse.IsFailed.ShouldBeTrue();
}

[Theory]
Expand Down
4 changes: 2 additions & 2 deletions TransactionProcessorACL.BusinessLogic/Services/ITransactionProcessorACLApplicationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ Task<Result<ProcessReconciliationResponse>> ProcessReconciliation(Guid estateId,
Decimal transactionValue,
CancellationToken cancellationToken);

Task<GetVoucherResponse> GetVoucher(Guid estateId,
Task<Result<GetVoucherResponse>> GetVoucher(Guid estateId,
Guid contractId,
String voucherCode,
CancellationToken cancellationToken);

Task<RedeemVoucherResponse> RedeemVoucher(Guid estateId,
Task<Result<RedeemVoucherResponse>> RedeemVoucher(Guid estateId,
Guid contractId,
String voucherCode,
CancellationToken cancellationToken);
Expand Down
Loading
Loading