Skip to content

[Refactor] Room Invite 코드 분리#200

Open
kwYoohae wants to merge 3 commits intodevfrom
feat-#199RoomFacade
Open

[Refactor] Room Invite 코드 분리#200
kwYoohae wants to merge 3 commits intodevfrom
feat-#199RoomFacade

Conversation

@kwYoohae
Copy link
Copy Markdown
Member

구현 목록

  • RoomService가 너무 복잡해짐에 따라서 Invite를 하는 ㅋ드 분리
  • RoomService 분리에 따른 test코드 분리
  • invite 코드가 기존과 같다면 재생성하는 코드 변경 (불필요한 db접근이라고 판단)

테스트 코드

image

@kwYoohae kwYoohae requested review from Icln and guswls159357 June 18, 2023 10:24
@kwYoohae kwYoohae self-assigned this Jun 18, 2023
@kwYoohae kwYoohae changed the base branch from master to dev June 19, 2023 07:32
Copy link
Copy Markdown
Member

@Icln Icln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@guswls159357 guswls159357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants