feat: support explicit field binding in QueryModelTypeModule#24
Merged
Conversation
When TraxQueryModelAttribute.BindFields is Explicit, the generated ObjectType calls BindFieldsExplicitly() and only binds properties with [Column] attributes. This prevents [NotMapped] aliases, DataLoader methods, and infrastructure methods from leaking into the schema.
2 tasks
|
This PR is included in version 1.16.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryModelTypeModulenow checksTraxQueryModelAttribute.BindFieldswhen creatingObjectType<T>Explicit, callsBindFieldsExplicitly()and auto-binds only[Column]-attributed properties[NotMapped]properties, methods, and non-column public members are excluded from the schemaObjectTypeExtension(custom TypeModules) still work since extensions are separateContext
Depends on TraxSharp/Trax.Effect#43 for the
FieldBindingBehaviorenum andBindFieldsattribute property.Test plan
dotnet buildpasses with zero warningsImplicit)BindFieldsthroughQueryModelRegistrationCreateTypesAsyncproduces correct types for both binding modes