test: raise coverage above 95% via auth callback and AddTraxGraphQL tests#44
Merged
Conversation
Adds direct unit tests for the OIDC and JWT OnTokenValidated event handlers (null principal, missing resolver, resolver throws, resolver returns null, short-circuit when an outer handler already set Result) plus the OIDC cookie 401/403 redirect handlers. Also covers AddTraxGraphQL's AddTrax guard, custom TypeModule registration, RequireAuthorization wiring, and UseTraxGraphQL endpoint mapping with and without an endpoint configurator.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.25.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnTokenValidatedhandlers (null principal, no resolver, resolver returns null, resolver throws, success path, outer-handler short-circuit). The existing tests only checked the events were wired.OnRedirectToLoginandOnRedirectToAccessDeniedhandlers (401 / 403 instead of redirects to /Account/Login).AddTraxGraphQLguard (throws whenAddTraxwas not called), customAddTypeModule<T>()registration through the reflection foreach,RequireAuthorizationwiring of the policy validator and request interceptor, andUseTraxGraphQLendpoint mapping with and without an endpoint configurator.Local cobertura: 93.63% to 95.96% across the project.
Test plan
dotnet testclean (782 passed, 1 pre-existing skipped)dotnet buildzero warningsdotnet csharpier format .applied