Skip to content

Use disposal-linked CancellationToken in dashboard dialogs #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Theauxm merged 1 commit into from
Mar 31, 2026
Merged

Use disposal-linked CancellationToken in dashboard dialogs #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/Trax.Dashboard/Components/Dialogs/QueueTrainDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@

namespace Trax.Dashboard.Components.Dialogs;

public partial class QueueTrainDialog
public partial class QueueTrainDialog : IDisposable
{
private readonly CancellationTokenSource _cts = new();

[Inject]
private IDataContextProviderFactory DataContextFactory { get; set; } = default!;

Expand Down Expand Up @@ -100,11 +102,9 @@ private async Task QueueTrain()
}
);

using var dataContext = await DataContextFactory.CreateDbContextAsync(
CancellationToken.None
);
using var dataContext = await DataContextFactory.CreateDbContextAsync(_cts.Token);
await dataContext.Track(entry);
await dataContext.SaveChanges(CancellationToken.None);
await dataContext.SaveChanges(_cts.Token);

DialogService.Close();
Navigation.NavigateTo($"trax/data/work-queue/{entry.Id}");
Expand Down Expand Up @@ -217,4 +217,10 @@ private static string GetPlaceholder(Type type) =>
"yyyy-MM-dd HH:mm:ss",
_ => $"Enter {type.Name}",
};

public void Dispose()
{
_cts.Cancel();
_cts.Dispose();
}
}
16 changes: 11 additions & 5 deletions src/Trax.Dashboard/Components/Dialogs/RunTrainDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@

namespace Trax.Dashboard.Components.Dialogs;

public partial class RunTrainDialog
public partial class RunTrainDialog : IDisposable
{
private readonly CancellationTokenSource _cts = new();

[Inject]
private IDataContextProviderFactory DataContextFactory { get; set; } = default!;

Expand Down Expand Up @@ -95,11 +97,9 @@ private async Task EnqueueTrain()
}
);

using var dataContext = await DataContextFactory.CreateDbContextAsync(
CancellationToken.None
);
using var dataContext = await DataContextFactory.CreateDbContextAsync(_cts.Token);
await dataContext.Track(metadata);
await dataContext.SaveChanges(CancellationToken.None);
await dataContext.SaveChanges(_cts.Token);

await JobSubmitter.EnqueueAsync(metadata.Id, input);

Expand Down Expand Up @@ -214,4 +214,10 @@ private static string GetPlaceholder(Type type) =>
"yyyy-MM-dd HH:mm:ss",
_ => $"Enter {type.Name}",
};

public void Dispose()
{
_cts.Cancel();
_cts.Dispose();
}
}
Loading