Extract shared dashboard patterns into reusable helpers#23
Merged
Conversation
Deduplicate batch operation wrappers, server-side pagination, cancel logic, and badge helpers that were copy-pasted across all data pages. - Add RunBatchOperationAsync, BatchError, BatchOperating to PollingComponentBase (replaces identical try/catch/finally in 10 methods across 5 pages) - Add DataGridQueryHelper.LoadPageAsync for server-side pagination (replaces identical 20-line methods in 4 pages) - Add CancellationHelper.CancelTrainsAsync for DB flag + registry cancel (replaces logic in MetadataPage, MetadataDetailPage, ManifestGroupDetailPage) - Move GetWorkQueueStatusBadgeStyle to DashboardFormatters (was duplicated in WorkQueuePage and WorkQueueDetailPage) - Add PausePolling to PollingComponentBase to skip refreshes while user has active checkbox selections
|
This PR is included in version 1.12.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunBatchOperationAsync,BatchError,BatchOperatingintoPollingComponentBase— replaces identical try/catch/finally wrappers in 10 batch methods across 5 data pagesDataGridQueryHelper.LoadPageAsync<T>— generic server-side pagination that replaces identical 20-lineLoadPageAsyncmethods in 4 pages (DeadLetters, WorkQueue, Metadata, Logs)CancellationHelper.CancelTrainsAsync— centralizes the "set DB flag + call CancellationRegistry" pattern used by MetadataPage, MetadataDetailPage, and ManifestGroupDetailPageGetWorkQueueStatusBadgeStyletoDashboardFormatters— was duplicated verbatim in WorkQueuePage and WorkQueueDetailPagePausePollingtoPollingComponentBase— skips poll refreshes while user has active checkbox selections, preventing data from being yanked out from under themNet result: -178 lines across 13 files, with all shared logic in 3 focused utility classes. Future pages get batch operations and pagination for free.
Test plan
dotnet build— zero warningsdotnet test— all 108 existing Dashboard tests pass + 4 newGetWorkQueueStatusBadgeStyletests