chore: ignore MSBuild static-graph restore cache + fix DI version pin#30
Merged
Conversation
*.csproj.lscache is produced by MSBuild's static graph restore and should not be checked in. Generated locally on every build/restore.
The integration tests pinned Microsoft.Extensions.DependencyInjection to 10.0.7, but EF Core InMemory 10.0.5 transitively requires Microsoft.Extensions.Logging 10.0.8 which depends on Microsoft.Extensions.DependencyInjection >= 10.0.8. NuGet flagged the downgrade as NU1605, which CI treats as a build error. Switch to the 10.* floating version other Trax test projects use so restore picks whatever floor the transitive closure requires. Unrelated to the .gitignore change in this branch; CI surfaced it on this PR because the failure is on main.
Theauxm
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated small changes:
*.csproj.lscache(MSBuild static-graph restore cache, regenerated on every build).Microsoft.Extensions.DependencyInjectioninTrax.Dashboard.Tests.Integrationfrom10.0.7to10.*to match the convention in other Trax test projects.Why the version fix
Microsoft.EntityFrameworkCore.InMemory 10.0.5now transitively pullsMicrosoft.Extensions.Logging 10.0.8which requiresMicrosoft.Extensions.DependencyInjection >= 10.0.8. With the test csproj pinning10.0.7, NuGet emits NU1605 (package downgrade) which CI promotes to a build error. The failure is on main already — the.gitignorechore just happened to surface it.Switching to the
10.*floating version pattern (already used inTrax.Api.Tests,Trax.Effect.Tests.Integration, etc.) lets the transitive closure pick whatever floor it needs without us having to chase point-version bumps.Test plan
dotnet restoresucceeds locally after the bump.