feat: rename Step to Junction#32
Merged
Merged
Conversation
Align code with documentation's railway metaphor where junctions are points on the route where work happens. This is a breaking change affecting all public APIs, NuGet package names, database columns, JSON wire format, and GraphQL schema.
Theauxm
force-pushed
the
feat/rename-step-to-junction
branch
from
1b037a5 to
948ac0c
Compare
|
This PR is included in version 1.19.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
Step<TIn, TOut>toJunction<TIn, TOut>across the entire codebase to align code with the documentation's railway metaphor, where junctions are "points on the route where work happens."This is a breaking change affecting:
Step<>→Junction<>,IStep<>→IJunction<>,EffectStep<>→EffectJunction<>*Step→*Junction(e.g.,LoadManifestsStep→LoadManifestsJunction)Trax.Core.Step→Trax.Core.JunctionTrax.Effect.StepProvider.*→Trax.Effect.JunctionProvider.*AddStepProgress()→AddJunctionProgress(),AddStepLogger()→AddJunctionLogger(), etc.failure_step→failure_junction,step_started_at→junction_started_at,currently_running_step→currently_running_junction"step"→"junction",failureStep→failureJunctionClean break with no
[Obsolete]shims. Migration029_rename_step_to_junction.sqlhandles the DB column renames.All repos build with zero warnings. 1,513 tests pass across all repos.
Test plan
dotnet buildzero warnings/errors in all 7 code reposdotnet csharpier check .passes in all repospack-local.shsucceeds with all new package names