Fix InMemory provider throwing on transaction use#37
Merged
Conversation
The InMemory EF Core provider throws by default when transactions are used. This breaks ScheduleMany and any other code path that calls BeginTransaction on an InMemory context. Adding ConfigureWarnings to ignore InMemoryEventId.TransactionIgnoredWarning lets transactions no-op silently instead of throwing.
|
This PR is included in version 1.23.1 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related bugs in the InMemory provider:
InMemoryContextProviderFactorydidn't suppressTransactionIgnoredWarning, so any code path callingBeginTransaction(e.g.TraxScheduler.ScheduleManyAsync) threw instead of no-opingIDataContextregistration inUseInMemory()each built their ownDbContextOptionsindependently, which caused EF Core InMemory to create separate database roots — manifests written viaScheduleMany(factory path) were invisible to polling services (scoped path)Fixed by introducing a shared
InMemoryDatabaseRootthat both the factory and the scoped registration use, with a singleBuildOptionsmethod that configures the database name, root, and transaction warning suppression consistently.Test plan
FactoryContext_And_ScopedContext_ShareSameDatabase— writes via factory, reads via scoped context, confirms shared data