Serialize output for lifecycle hooks without SaveTrainParameters#40
Merged
Serialize output for lifecycle hooks without SaveTrainParameters#40
Conversation
When SaveTrainParameters() is not configured, Metadata.Output was null during OnCompleted hooks. Now serializes the output object to JSON after SaveChanges but before firing lifecycle hooks, so hook consumers can read Metadata.Output without requiring the parameter provider.
|
This PR is included in version 1.24.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SaveTrainParameters()is not configured,Metadata.Outputwas null duringOnCompletedhooksSaveChangesbut before firing lifecycle hooksTest plan
Run_WithoutSaveTrainParameters_OnCompletedHasSerializedOutput— verifies Output is populatedRun_WithoutSaveTrainParameters_OutputContainsCorrectData— verifies deserialized content matchesRun_WithoutSaveTrainParameters_GetOutputObjectStillAvailable— verifies GetOutputObject() still works