Fix CancellationToken loss and InProgress metadata orphaning#45
Merged
Conversation
…ogress gap Run(input, metadata, ct) and Run(input, metadata) called Run(input) which overwrote the token with CancellationToken.None, breaking dashboard same-server cancellation and Lambda timeout propagation. Moved LifecycleHookRunner.OnStarted inside the main try/catch so any failure after InProgress is persisted calls FinishServiceTrain instead of orphaning metadata.
|
This PR is included in version 1.28.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run(input, metadata, ct)andRun(input, metadata)calledRun(input)which hit the 2-param overloadRun(TIn, CancellationToken = default), overwriting the real token withCancellationToken.None. This broke dashboard same-server cancellation (viaCancellationRegistry.TryCancel) and Lambda timeout propagation. Both now pass the token explicitly.LifecycleHookRunner.OnStartedran outside the try/catch that callsFinishServiceTrain. If it threw, metadata stayed stuck in InProgress forever. Moved it inside the existing try/catch block.Test plan