Conversation
…operties DataContext.Track and Update used base.Update(model) which traverses the entire entity graph, marking loaded navigation properties (like Manifest) as Modified. This generated unnecessary UPDATE statements that caused lock contention with MetadataCleanupTrain, hanging Lambda workers on dormant dependent trains. Replace with direct entry.State assignment which only affects the target entity. Also fix EffectRunner.Track/Update to properly await async provider calls (was fire-and-forget via sync RunAll).
|
This PR is included in version 1.28.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base.Update(model)which traverses the entire entity graph via EF Core's graph walker. When metadata had an eagerly-loaded Manifest (fromLoadMetadataJunction.Include(x => x.Manifest)), the Manifest was marked Modified, generating unnecessaryUPDATE trax.manifeststatements that caused lock contention with MetadataCleanupTrain's long-running DELETE — hanging Lambda workers on dormant dependent trains indefinitely.base.Update(model)with directentry.Stateassignment, which only affects the target entity without traversing navigations. Preserves the same key heuristic (Id > 0 → Modified, Id == 0 → Added).await RunAllAsyncinstead of fire-and-forget via syncRunAll. All current providers are synchronous so this was latent, but prevents future async providers from silently failing.Test plan
Task.Yield()