Read TrainExceptionData from Exception.Data in AddException#50
Merged
Conversation
Update Metadata.AddException to prefer structured data from Exception.Data over JSON message deserialization. Add E2E tests verifying failure fields persist correctly through the full pipeline for dashboard/API/broadcaster.
|
This PR is included in version 1.30.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metadata.AddExceptionto read structuredTrainExceptionDatafromException.Datafirst (local execution), fall back to JSON message deserialization (remote/legacy), then plain exceptionTrainExceptionData.StackTraceover the re-thrown exception's stack traceTest plan
ExceptionPersistenceTests— 15 E2E tests against InMemory provider: junction failures, HTTP errors, JSON messages, special chars, multi-junction, database round-trip, dashboard/API compatibilityBroadcastLifecycleHookTests— failure fields flow correctly to broadcaster with TrainExceptionData