test: cover Trax attributes and ValueTupleConverter#57
Merged
Conversation
…tes and ValueTupleConverter
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
|
This PR is included in version 1.34.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests for attribute classes that were sitting at 0% line coverage:
TraxAuthorizeAttribute— default ctor, policy ctor,Rolesinit propertyTraxConcurrencyLimitAttribute— valid limits, plus the>= 1guard (rejects 0 and negatives)TraxQueryAttribute— defaults and full init-property surfaceTraxQueryModelAttribute— defaults (Paging/Filtering/Sorting/Projection= true,BindFields=Implicit) and overridesAlso adds a small
ValueTupleConvertertest covering theCanConvertpredicate, the serialize path, and the wrong-array-length JsonException branch.Local line coverage on Trax.Effect moved from ~80% to ~81% with these. The remaining gap to 90% is in code that needs infrastructure (RabbitMQ broadcaster, DataContext logging, EffectJunction runtime) — separate PRs.
Test plan
dotnet test tests/Trax.Effect.Tests.Integration— passing (14 new)dotnet csharpier check .— clean