test: cover EffectJunction railway, runners, and effect builder overloads#58
Merged
test: cover EffectJunction railway, runners, and effect builder overloads#58
Conversation
…fecycleHookRunner exception path, and AddEffect/AddJunctionEffect/AddLifecycleHook/AddTraxJunction overloads" This reverts commit 2889fff.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.34.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds direct tests for code paths that were sitting in the 60-80% range:
EffectJunction.RailwayJunction— non-ServiceTraintrain throw, null-Metadatathrow, happy-path metadata population, and theJunctionEffectRunner.Before/AftercallbacksJunctionEffectRunner.BeforeJunctionExecution/AfterJunctionExecution— dispatch to active providersLifecycleHookRunner.OnStateChanged— exception in one hook is logged and the next hook still runsTraxEffectBuilder.AddEffect(factoryInstance)and the threeAddJunctionEffectoverloadsTraxEffectBuilder.AddLifecycleHookoverloads, including theInvalidOperationExceptionthrown whenTimplements neitherITrainLifecycleHooknorITrainLifecycleHookFactoryAddScopedTraxJunction/AddTransientTraxJunction/AddSingletonTraxJunctionruntime-TypeoverloadsAlso adds NSubstitute to
Trax.Effect.Tests.Integration(already in use elsewhere in the workspace).Trax.Effect(main lib) line coverage moves from ~88% to ~94%. Aggregate Effect coverage moves from ~80% to ~84% — the remaining gap is RabbitMQ broadcaster (no infra) and DataContext logging providers (postgres-backed).Test plan
dotnet test— all suites pass (16 new)dotnet csharpier check .— clean